From 5bb121911e9b60704154bbc89e238b97439e2bcf Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Mon, 20 Apr 2026 09:38:01 +0300 Subject: z4: fix verification lint cleanup --- cmd/comicforge/cli.go | 2 +- cmd/comicforge/cli_test.go | 18 ++++++++++++++---- 2 files changed, 15 insertions(+), 5 deletions(-) (limited to 'cmd') diff --git a/cmd/comicforge/cli.go b/cmd/comicforge/cli.go index 270ed72..9da2eb3 100644 --- a/cmd/comicforge/cli.go +++ b/cmd/comicforge/cli.go @@ -77,7 +77,7 @@ func newRootCommandWithDeps(deps commandDeps) *cobra.Command { SilenceErrors: true, RunE: func(cmd *cobra.Command, args []string) error { if flags.version { - fmt.Fprintln(cmd.OutOrStdout(), version.Version) + _, _ = fmt.Fprintln(cmd.OutOrStdout(), version.Version) return nil } if strings.TrimSpace(flags.vocab) == "" { diff --git a/cmd/comicforge/cli_test.go b/cmd/comicforge/cli_test.go index 809a839..4cf49f8 100644 --- a/cmd/comicforge/cli_test.go +++ b/cmd/comicforge/cli_test.go @@ -9,6 +9,9 @@ import ( "strings" "testing" + "github.com/spf13/cobra" + "github.com/spf13/pflag" + version "codeberg.org/snonux/comicforge/internal" "codeberg.org/snonux/comicforge/internal/comic" "codeberg.org/snonux/comicforge/internal/config" @@ -254,10 +257,7 @@ func TestRootCommandRejectsConflictingUltraFlags(t *testing.T) { func TestRootCommandProviderFlagsDefaultToGemini(t *testing.T) { cmd := newRootCommand() for _, flagName := range []string{"text-provider", "image-provider", "tts-provider"} { - flag := cmd.Flags().Lookup(flagName) - if flag == nil { - t.Fatalf("flag %q not found", flagName) - } + flag := mustLookupFlag(t, cmd, flagName) if got, want := flag.DefValue, provider.Gemini; got != want { t.Fatalf("%s default = %q, want %q", flagName, got, want) } @@ -317,6 +317,16 @@ func TestRootCommandSkipsTTSProviderWhenNarrationDisabled(t *testing.T) { } } +func mustLookupFlag(t *testing.T, cmd *cobra.Command, name string) *pflag.Flag { + t.Helper() + + flag := cmd.Flags().Lookup(name) + if flag == nil { + t.Fatalf("flag %q not found", name) + } + return flag +} + type recordingRunner struct { cfg *comic.RunnerConfig batchFile string -- cgit v1.2.3