From 2b4c9a57ba522cd8dd01dc1f1d2761b66f97e4f2 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Sat, 31 May 2008 02:24:26 +0000
Subject: more elegant way to remove not relevantmessages.

---
 sources/events/internal/VSMessageReceiveEvent.java | 32 +++++++++++++++-------
 sources/events/internal/VSProtocolEvent.java       |  4 +--
 .../events/internal/VSProtocolScheduleEvent.java   |  4 +--
 3 files changed, 24 insertions(+), 16 deletions(-)

(limited to 'sources/events/internal')

diff --git a/sources/events/internal/VSMessageReceiveEvent.java b/sources/events/internal/VSMessageReceiveEvent.java
index d53d019..0cffa86 100644
--- a/sources/events/internal/VSMessageReceiveEvent.java
+++ b/sources/events/internal/VSMessageReceiveEvent.java
@@ -59,27 +59,21 @@ public class VSMessageReceiveEvent extends VSAbstractEvent {
     /* (non-Javadoc)
      * @see events.VSAbstractEvent#onStart()
      */
-    public boolean onStart() {
-        boolean returnValue = true;
+    public void onStart() {
         boolean onlyRelevantMessages = process.getPrefs().getBoolean(
                                            "sim.messages.relevant");
 
         String eventName = message.getName();
         String protocolClassname = message.getProtocolClassname();
 
+        if (onlyRelevantMessages && !isRelevantMessage())
+            return;
+
         Object protocolObj = null;
 
         if (process.objectExists(protocolClassname))
             protocolObj = process.getObject(protocolClassname);
 
-        if (onlyRelevantMessages) {
-            if (protocolObj == null)
-                return false;
-
-            if (!((VSAbstractProtocol) protocolObj).isRelevantMessage(message))
-                return false;
-        }
-
         process.updateLamportTime(message.getLamportTime()+1);
         process.updateVectorTime(message.getVectorTime());
 
@@ -91,6 +85,24 @@ public class VSMessageReceiveEvent extends VSAbstractEvent {
 
         if (protocolObj != null)
             ((VSAbstractProtocol) protocolObj).onMessageRecvStart(message);
+    }
+
+    /**
+     * Checks if the message delivering is relevant.
+     *
+     * @return true, if relevant
+     */
+    public boolean isRelevantMessage() {
+        String protocolClassname = message.getProtocolClassname();
+        Object protocolObj = null;
+
+        if (process.objectExists(protocolClassname))
+            protocolObj = process.getObject(protocolClassname);
+        else
+            return false;
+
+        if (!((VSAbstractProtocol) protocolObj).isRelevantMessage(message))
+            return false;
 
         return true;
     }
diff --git a/sources/events/internal/VSProtocolEvent.java b/sources/events/internal/VSProtocolEvent.java
index d3efcb2..cfb1e35 100644
--- a/sources/events/internal/VSProtocolEvent.java
+++ b/sources/events/internal/VSProtocolEvent.java
@@ -107,7 +107,7 @@ public class VSProtocolEvent extends VSAbstractEvent {
     /* (non-Javadoc)
      * @see events.VSAbstractEvent#onStart()
      */
-    public boolean onStart() {
+    public void onStart() {
         VSAbstractProtocol protocol =
             process.getProtocolObject(protocolClassname);
 
@@ -131,7 +131,5 @@ public class VSProtocolEvent extends VSAbstractEvent {
                       : prefs.getString("lang.deactivated"));
 
         logg(buffer.toString());
-
-        return true;
     }
 }
diff --git a/sources/events/internal/VSProtocolScheduleEvent.java b/sources/events/internal/VSProtocolScheduleEvent.java
index 3bbac19..912b552 100644
--- a/sources/events/internal/VSProtocolScheduleEvent.java
+++ b/sources/events/internal/VSProtocolScheduleEvent.java
@@ -104,12 +104,10 @@ public class VSProtocolScheduleEvent extends VSAbstractEvent {
     /* (non-Javadoc)
      * @see events.VSAbstractEvent#onStart()
      */
-    public boolean onStart() {
+    public void onStart() {
         if (isServerSchedule)
             protocol.onServerScheduleStart();
         else
             protocol.onClientScheduleStart();
-
-        return true;
     }
 }
-- 
cgit v1.2.3