From 785d379ca02f4488d39e8952e9ae5bea673cd930 Mon Sep 17 00:00:00 2001
From: Paul Buetow <pbuetow@mimecast.com>
Date: Thu, 9 Dec 2021 09:30:31 +0000
Subject: Refactor result method

---
 internal/mapr/groupset.go | 105 +++++++++++++++++++++++++++-------------------
 1 file changed, 63 insertions(+), 42 deletions(-)

diff --git a/internal/mapr/groupset.go b/internal/mapr/groupset.go
index 39b0b17..2370d89 100644
--- a/internal/mapr/groupset.go
+++ b/internal/mapr/groupset.go
@@ -260,68 +260,89 @@ func (g *GroupSet) writeResult(query *Query, rows []result, tmpOutfile string,
 
 // Return a sorted result slice of the query from the group set.
 func (g *GroupSet) result(query *Query, gatherWidths bool) ([]result, []int, error) {
+	var err error
 	var rows []result
+
+	// Helpers for calculating the ASCII table output (output is the terminal and
+	// not a CSV file).
 	widths := make([]int, len(query.Select))
-	var valueStr string
-	var value float64
+	var valueStrLen int
 
 	for groupKey, set := range g.sets {
-		r := result{groupKey: groupKey}
+		result := result{groupKey: groupKey}
 
 		for i, sc := range query.Select {
-			switch sc.Operation {
-			case Count:
-				value = set.FValues[sc.FieldStorage]
-				valueStr = fmt.Sprintf("%d", int(value))
-			case Len:
-				fallthrough
-			case Sum:
-				fallthrough
-			case Min:
-				fallthrough
-			case Max:
-				value = set.FValues[sc.FieldStorage]
-				valueStr = fmt.Sprintf("%f", value)
-			case Last:
-				valueStr = set.SValues[sc.FieldStorage]
-				value, _ = strconv.ParseFloat(valueStr, 64)
-			case Avg:
-				value = set.FValues[sc.FieldStorage] / float64(set.Samples)
-				valueStr = fmt.Sprintf("%f", value)
-			default:
-				return rows, widths, fmt.Errorf("Unknown aggregation method '%v'",
-					sc.Operation)
-			}
-
-			if sc.FieldStorage == query.OrderBy {
-				r.orderBy = value
+			if valueStrLen, err = g.resultSelect(query, &sc, set, &result); err != nil {
+				return rows, widths, err
 			}
-			r.values = append(r.values, valueStr)
 
+			// Do we want to gather the table withs? This is required to print out a decent
+			// ASCII formated table (table output is the terminal and not a CSV file).
 			if !gatherWidths {
 				continue
 			}
 			if widths[i] < len(sc.FieldStorage) {
 				widths[i] = len(sc.FieldStorage)
 			}
-			if widths[i] < len(valueStr) {
-				widths[i] = len(valueStr)
+			if widths[i] < valueStrLen {
+				widths[i] = valueStrLen
 			}
 		}
-		rows = append(rows, r)
+		rows = append(rows, result)
 	}
 
 	if query.OrderBy != "" {
-		if query.ReverseOrder {
-			sort.SliceStable(rows, func(i, j int) bool {
-				return rows[i].orderBy < rows[j].orderBy
-			})
-		} else {
-			sort.SliceStable(rows, func(i, j int) bool {
-				return rows[i].orderBy > rows[j].orderBy
-			})
-		}
+		g.resultOrderBy(query, rows)
 	}
 
 	return rows, widths, nil
 }
+
+func (*GroupSet) resultSelect(query *Query, sc *selectCondition, set *AggregateSet,
+	result *result) (int, error) {
+
+	var valueStr string
+	var value float64
+
+	switch sc.Operation {
+	case Count:
+		value = set.FValues[sc.FieldStorage]
+		valueStr = fmt.Sprintf("%d", int(value))
+	case Len:
+		fallthrough
+	case Sum:
+		fallthrough
+	case Min:
+		fallthrough
+	case Max:
+		value = set.FValues[sc.FieldStorage]
+		valueStr = fmt.Sprintf("%f", value)
+	case Last:
+		valueStr = set.SValues[sc.FieldStorage]
+		value, _ = strconv.ParseFloat(valueStr, 64)
+	case Avg:
+		value = set.FValues[sc.FieldStorage] / float64(set.Samples)
+		valueStr = fmt.Sprintf("%f", value)
+	default:
+		return 0, fmt.Errorf("Unknown aggregation method '%v'", sc.Operation)
+	}
+
+	if sc.FieldStorage == query.OrderBy {
+		result.orderBy = value
+	}
+	result.values = append(result.values, valueStr)
+
+	return len(valueStr), nil
+}
+
+func (*GroupSet) resultOrderBy(query *Query, rows []result) {
+	if query.ReverseOrder {
+		sort.SliceStable(rows, func(i, j int) bool {
+			return rows[i].orderBy < rows[j].orderBy
+		})
+	} else {
+		sort.SliceStable(rows, func(i, j int) bool {
+			return rows[i].orderBy > rows[j].orderBy
+		})
+	}
+}
-- 
cgit v1.2.3