From e70adfe0d309d511ae7598683003c92795192fe1 Mon Sep 17 00:00:00 2001
From: Paul Buetow <pbuetow@mimecast.com>
Date: Wed, 8 Dec 2021 09:52:21 +0000
Subject: refactor dmap1 unit test to be more modular

---
 integrationtests/dmap1.csv.expected        |  2 --
 integrationtests/dmap1.csv.query.expected  |  1 -
 integrationtests/dmap1a.csv.expected       |  2 ++
 integrationtests/dmap1a.csv.query.expected |  1 +
 integrationtests/dmap_test.go              | 21 +++++++++++----------
 5 files changed, 14 insertions(+), 13 deletions(-)
 delete mode 100644 integrationtests/dmap1.csv.expected
 delete mode 100644 integrationtests/dmap1.csv.query.expected
 create mode 100644 integrationtests/dmap1a.csv.expected
 create mode 100644 integrationtests/dmap1a.csv.query.expected

(limited to 'integrationtests')

diff --git a/integrationtests/dmap1.csv.expected b/integrationtests/dmap1.csv.expected
deleted file mode 100644
index d4e6f0f..0000000
--- a/integrationtests/dmap1.csv.expected
+++ /dev/null
@@ -1,2 +0,0 @@
-count($line),last($time),avg($goroutines),min(concurrentconnections),max(lifetimeconnections)
-597,20211002-071949,11.628141,0.000000,6.000000
diff --git a/integrationtests/dmap1.csv.query.expected b/integrationtests/dmap1.csv.query.expected
deleted file mode 100644
index f47670a..0000000
--- a/integrationtests/dmap1.csv.query.expected
+++ /dev/null
@@ -1 +0,0 @@
-from STATS select count($line),last($time),avg($goroutines),min(concurrentConnections),max(lifetimeConnections) group by $hostname outfile dmap1.csv.tmp
\ No newline at end of file
diff --git a/integrationtests/dmap1a.csv.expected b/integrationtests/dmap1a.csv.expected
new file mode 100644
index 0000000..d4e6f0f
--- /dev/null
+++ b/integrationtests/dmap1a.csv.expected
@@ -0,0 +1,2 @@
+count($line),last($time),avg($goroutines),min(concurrentconnections),max(lifetimeconnections)
+597,20211002-071949,11.628141,0.000000,6.000000
diff --git a/integrationtests/dmap1a.csv.query.expected b/integrationtests/dmap1a.csv.query.expected
new file mode 100644
index 0000000..dcc63ca
--- /dev/null
+++ b/integrationtests/dmap1a.csv.query.expected
@@ -0,0 +1 @@
+from STATS select count($line),last($time),avg($goroutines),min(concurrentConnections),max(lifetimeConnections) group by $hostname outfile dmap1a.csv.tmp
\ No newline at end of file
diff --git a/integrationtests/dmap_test.go b/integrationtests/dmap_test.go
index 5e5f4d3..ec14cfb 100644
--- a/integrationtests/dmap_test.go
+++ b/integrationtests/dmap_test.go
@@ -15,28 +15,29 @@ func TestDMap1(t *testing.T) {
 		return
 	}
 
+	query := fmt.Sprintf("from STATS select count($line),last($time)," +
+		"avg($goroutines),min(concurrentConnections),max(lifetimeConnections) " +
+		"group by $hostname")
+
 	t.Log("Testing dmap with input file")
-	if err := testDmap1(t, false); err != nil {
+	if err := testDmap1(t, query, "a", false); err != nil {
 		t.Error(err)
 		return
 	}
 	t.Log("Testing dmap with stdin input pipe")
-	if err := testDmap1(t, true); err != nil {
+	if err := testDmap1(t, query, "a", true); err != nil {
 		t.Error(err)
 		return
 	}
 }
 
-func testDmap1(t *testing.T, usePipe bool) error {
+func testDmap1(t *testing.T, query, subtestName string, usePipe bool) error {
 	inFile := "mapr_testdata.log"
-	csvFile := "dmap1.csv.tmp"
-	expectedCsvFile := "dmap1.csv.expected"
+	csvFile := fmt.Sprintf("dmap1%s.csv.tmp", subtestName)
+	expectedCsvFile := fmt.Sprintf("dmap1%s.csv.expected", subtestName)
 	queryFile := fmt.Sprintf("%s.query", csvFile)
-	expectedQueryFile := "dmap1.csv.query.expected"
-
-	query := fmt.Sprintf("from STATS select count($line),last($time),"+
-		"avg($goroutines),min(concurrentConnections),max(lifetimeConnections) "+
-		"group by $hostname outfile %s", csvFile)
+	expectedQueryFile := fmt.Sprintf("dmap1%s.csv.query.expected", subtestName)
+	query = fmt.Sprintf("%s outfile %s", query, csvFile)
 
 	ctx, cancel := context.WithCancel(context.Background())
 	defer cancel()
-- 
cgit v1.2.3