From 849951be1d1a7ee9f9302006ccb187bf5b4e36f3 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Wed, 22 Jul 2026 23:51:18 +0300 Subject: =?UTF-8?q?feat:=20DTail=20fork=20=E2=80=94=20server/client=20feat?= =?UTF-8?q?ure=20development?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Squashed development of the snonux/dtail fork's product code (internal/, cmd/) since diverging from mimecast/dtail. Major areas: - Read/output path: the former "turbo" channel-less path is now the single, default server-side read/output path for cat/grep/tail and MapReduce; the old channel-based path and its config/env toggles were removed. - MapReduce: single aggregate implementation (server + serverless) fed directly by a processor pipeline, with input-exhausted finalization via the shutdown coordinator; high-concurrency and data-race fixes. - Journal source reads (journal:unit.service) via journalctl, Linux-gated behind a journal-v1 capability. - Auth-key fast reconnect: in-memory per-user public-key cache with TTL/max-keys, registered over an authenticated session (AUTHKEY), checked before authorized_keys. - Interactive query reload (--interactive-query) with SESSION START/UPDATE generation boundaries and capability negotiation. - Client-side deadlines: --timeout / --shutdownAfter as context deadlines; follow shutdown handling. - Client logging: diagnostics-only daily log by default, opt-in payload tee via --log-payload. - Numerous correctness fixes (buffer-pool double-recycle races, EOF-sentinel leaks, glob-expansion cap, TOCTOU in CSV parsing) with accompanying unit tests. Co-Authored-By: Claude Opus 4.8 --- internal/io/fs/rootedpath_test.go | 57 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 57 insertions(+) create mode 100644 internal/io/fs/rootedpath_test.go (limited to 'internal/io/fs/rootedpath_test.go') diff --git a/internal/io/fs/rootedpath_test.go b/internal/io/fs/rootedpath_test.go new file mode 100644 index 0000000..a3dc84b --- /dev/null +++ b/internal/io/fs/rootedpath_test.go @@ -0,0 +1,57 @@ +package fs + +import ( + "bytes" + "os" + "path/filepath" + "testing" +) + +func TestRootedPathReadWrite(t *testing.T) { + dir := t.TempDir() + filePath := filepath.Join(dir, "known_hosts") + rootedPath, err := NewRootedPath(filePath) + if err != nil { + t.Fatalf("NewRootedPath failed: %v", err) + } + + want := []byte("trusted host\n") + if err := rootedPath.WriteFile(want, 0o600); err != nil { + t.Fatalf("WriteFile failed: %v", err) + } + + got, err := rootedPath.ReadFile() + if err != nil { + t.Fatalf("ReadFile failed: %v", err) + } + if !bytes.Equal(got, want) { + t.Fatalf("ReadFile returned %q, want %q", got, want) + } +} + +func TestRootedPathReadFileRejectsEscapingSymlink(t *testing.T) { + dir := t.TempDir() + rootDir := filepath.Join(dir, "ssh") + if err := os.MkdirAll(rootDir, 0o755); err != nil { + t.Fatalf("MkdirAll failed: %v", err) + } + + outsidePath := filepath.Join(dir, "outside_authorized_keys") + if err := os.WriteFile(outsidePath, []byte("outside\n"), 0o600); err != nil { + t.Fatalf("WriteFile failed: %v", err) + } + + linkPath := filepath.Join(rootDir, "authorized_keys") + if err := os.Symlink(filepath.Join("..", "outside_authorized_keys"), linkPath); err != nil { + t.Fatalf("Symlink failed: %v", err) + } + + rootedPath, err := NewRootedPath(linkPath) + if err != nil { + t.Fatalf("NewRootedPath failed: %v", err) + } + + if _, err := rootedPath.ReadFile(); err == nil { + t.Fatalf("ReadFile succeeded for escaping symlink") + } +} -- cgit v1.2.3