From 849951be1d1a7ee9f9302006ccb187bf5b4e36f3 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Wed, 22 Jul 2026 23:51:18 +0300 Subject: =?UTF-8?q?feat:=20DTail=20fork=20=E2=80=94=20server/client=20feat?= =?UTF-8?q?ure=20development?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Squashed development of the snonux/dtail fork's product code (internal/, cmd/) since diverging from mimecast/dtail. Major areas: - Read/output path: the former "turbo" channel-less path is now the single, default server-side read/output path for cat/grep/tail and MapReduce; the old channel-based path and its config/env toggles were removed. - MapReduce: single aggregate implementation (server + serverless) fed directly by a processor pipeline, with input-exhausted finalization via the shutdown coordinator; high-concurrency and data-race fixes. - Journal source reads (journal:unit.service) via journalctl, Linux-gated behind a journal-v1 capability. - Auth-key fast reconnect: in-memory per-user public-key cache with TTL/max-keys, registered over an authenticated session (AUTHKEY), checked before authorized_keys. - Interactive query reload (--interactive-query) with SESSION START/UPDATE generation boundaries and capability negotiation. - Client-side deadlines: --timeout / --shutdownAfter as context deadlines; follow shutdown handling. - Client logging: diagnostics-only daily log by default, opt-in payload tee via --log-payload. - Numerous correctness fixes (buffer-pool double-recycle races, EOF-sentinel leaks, glob-expansion cap, TOCTOU in CSV parsing) with accompanying unit tests. Co-Authored-By: Claude Opus 4.8 --- internal/server/handlers/protocol_codec_test.go | 32 +++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 internal/server/handlers/protocol_codec_test.go (limited to 'internal/server/handlers/protocol_codec_test.go') diff --git a/internal/server/handlers/protocol_codec_test.go b/internal/server/handlers/protocol_codec_test.go new file mode 100644 index 0000000..a182d18 --- /dev/null +++ b/internal/server/handlers/protocol_codec_test.go @@ -0,0 +1,32 @@ +package handlers + +import ( + "strings" + "testing" + + "github.com/mimecast/dtail/internal/protocol" +) + +func TestHandleProtocolVersionUsesSemanticCompatComparison(t *testing.T) { + codec := newProtocolCodec(nil) + + args, argc, add, err := codec.handleProtocolVersion([]string{"protocol", "4", "tail", "payload"}) + if err == nil { + t.Fatal("expected protocol mismatch error") + } + if argc != 4 { + t.Fatalf("unexpected argc: got %d want 4", argc) + } + if len(args) != 4 || args[0] != "protocol" || args[1] != "4" { + t.Fatalf("unexpected args returned: %#v", args) + } + if add != "" { + t.Fatalf("unexpected message separator: %q", add) + } + if !strings.Contains(err.Error(), "please update DTail client") { + t.Fatalf("expected client update guidance, got %q", err) + } + if !strings.Contains(err.Error(), protocol.ProtocolCompat) { + t.Fatalf("expected error to mention server protocol version, got %q", err) + } +} -- cgit v1.2.3