From 1d096119505b2eca99ff445644cce94ac0d8b3b8 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Sat, 29 Feb 2020 17:27:10 +0000 Subject: race condition --- internal/server/handlers/serverhandler.go | 2 -- 1 file changed, 2 deletions(-) (limited to 'internal/server/handlers') diff --git a/internal/server/handlers/serverhandler.go b/internal/server/handlers/serverhandler.go index 819cddd..b638e69 100644 --- a/internal/server/handlers/serverhandler.go +++ b/internal/server/handlers/serverhandler.go @@ -250,7 +250,6 @@ func (h *ServerHandler) handleUserCommand(ctx context.Context, argc int, args [] splitted := strings.Split(args[0], ":") command := splitted[0] - // TODO: Refactor: Create an "options" clase, combine makeOptions and readOptions there. options, err := readOptions(splitted[1:]) if err != nil { h.sendServerMessage(logger.Error(h.user, err)) @@ -332,7 +331,6 @@ func (h *ServerHandler) handleUserCommand(ctx context.Context, argc int, args [] if background { commandCtx, cancel := context.WithCancel(h.serverCtx) - // TODO: For background jobs dont attempt to send data to dtail client as there might be no SSH connection if err := h.background.Add(h.user.Name, jobName, cancel, &wg); err != nil { h.sendServerMessage(logger.Error(h.user, err, jobName, args)) finished() -- cgit v1.2.3