From 599bdb74efcc97e86ce6023c1ae8265b1c2ff33b Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Thu, 29 Jan 2026 21:39:06 +0200
Subject: refactor: improve Go best practices compliance

- Add explicit interface satisfaction checks (var _ Interface = (*Type)(nil)) for compile-time verification:
  - TurboWriter implementations (DirectTurboWriter, TurboChannelWriter)
  - Processor implementations (GrepLineProcessor, ChannellessLineProcessor)
  - Parser implementations (genericParser, csvParser, genericKVParser, custom parsers, mimecastParser)
  - Logger implementations (file, stdout)
  - Handler implementations (ServerHandler, ClientHandler)
  - Connector implementations (Serverless, ServerConnection)
  - SSH callback implementations (KnownHostsCallback)

- Improve error handling with context wrapping (%w):
  - SSH operations: GeneratePrivateRSAKey, Agent
  - Query parsing: Query.parse
  - SSH client connections: dial, session, handle methods

- Fix receiver consistency:
  - Convert Query.String() from value to pointer receiver
  - Convert Outfile.String() from value to pointer receiver
  - Convert all KnownHostsCallback methods to pointer receivers
  - Convert mapCommand.Start() to pointer receiver

- Reorganize file structure for better clarity:
  - internal/io/dlog/dlog.go: Move type definition before public functions
  - internal/mapr/token.go: Reorganize helper functions after public ones

- Add documentation comments:
  - Query.String() method
  - Outfile.String() method
  - Regex.String() method
  - Improve config variable documentation

All unit tests and integration tests pass.

Amp-Thread-ID: https://ampcode.com/threads/T-019c0b08-0eeb-705d-a1f7-31bb764b659a
Co-authored-by: Amp <amp@ampcode.com>
---
 internal/ssh/client/knownhostscallback.go | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

(limited to 'internal/ssh/client')

diff --git a/internal/ssh/client/knownhostscallback.go b/internal/ssh/client/knownhostscallback.go
index fe3543c..9c73864 100644
--- a/internal/ssh/client/knownhostscallback.go
+++ b/internal/ssh/client/knownhostscallback.go
@@ -45,6 +45,8 @@ type KnownHostsCallback struct {
 	mutex           *sync.Mutex
 }
 
+var _ HostKeyCallback = (*KnownHostsCallback)(nil)
+
 // NewKnownHostsCallback returns a new wrapper.
 func NewKnownHostsCallback(knownHostsPath string, trustAllHosts bool,
 	throttleCh chan struct{}) (HostKeyCallback, error) {
@@ -63,11 +65,11 @@ func NewKnownHostsCallback(knownHostsPath string, trustAllHosts bool,
 	if trustAllHosts {
 		close(c.trustAllHostsCh)
 	}
-	return c, nil
+	return &c, nil
 }
 
 // Wrap the host key callback.
-func (c KnownHostsCallback) Wrap() ssh.HostKeyCallback {
+func (c *KnownHostsCallback) Wrap() ssh.HostKeyCallback {
 	return func(server string, remote net.Addr, key ssh.PublicKey) error {
 		// Parse known_hosts file
 		knownHostsCb, err := knownhosts.New(c.knownHostsPath)
@@ -113,7 +115,7 @@ func (c KnownHostsCallback) Wrap() ssh.HostKeyCallback {
 
 // PromptAddHosts prompts a question to the user whether unknown hosts should
 // be added to the known hosts or not.
-func (c KnownHostsCallback) PromptAddHosts(ctx context.Context) {
+func (c *KnownHostsCallback) PromptAddHosts(ctx context.Context) {
 	var hosts []unknownHost
 	for {
 		// Check whether there is a unknown host
@@ -138,7 +140,7 @@ func (c KnownHostsCallback) PromptAddHosts(ctx context.Context) {
 	}
 }
 
-func (c KnownHostsCallback) promptAddHosts(hosts []unknownHost) {
+func (c *KnownHostsCallback) promptAddHosts(hosts []unknownHost) {
 	var servers []string
 	for _, host := range hosts {
 		servers = append(servers, host.server)
@@ -212,7 +214,7 @@ func (c KnownHostsCallback) promptAddHosts(hosts []unknownHost) {
 	p.Ask()
 }
 
-func (c KnownHostsCallback) trustHosts(hosts []unknownHost) {
+func (c *KnownHostsCallback) trustHosts(hosts []unknownHost) {
 	tmpKnownHostsPath := fmt.Sprintf("%s.tmp", c.knownHostsPath)
 
 	newFd, err := os.OpenFile(tmpKnownHostsPath, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0600)
@@ -265,14 +267,14 @@ func (c KnownHostsCallback) trustHosts(hosts []unknownHost) {
 	}
 }
 
-func (c KnownHostsCallback) dontTrustHosts(hosts []unknownHost) {
+func (c *KnownHostsCallback) dontTrustHosts(hosts []unknownHost) {
 	for _, unknown := range hosts {
 		unknown.responseCh <- dontTrustHost
 	}
 }
 
 // Untrusted returns true if the host is not trusted. False otherwise.
-func (c KnownHostsCallback) Untrusted(server string) bool {
+func (c *KnownHostsCallback) Untrusted(server string) bool {
 	c.mutex.Lock()
 	defer c.mutex.Unlock()
 	_, ok := c.untrustedHosts[server]
-- 
cgit v1.2.3