From 2393a41e6b9f6e5ffa7a212a1727c1a1a7bf64d9 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Wed, 4 Mar 2026 21:15:35 +0200 Subject: fix: avoid defer-in-loop cancel in base client retry (task 359) --- internal/clients/baseclient.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'internal') diff --git a/internal/clients/baseclient.go b/internal/clients/baseclient.go index ad90c8d..adc2b77 100644 --- a/internal/clients/baseclient.go +++ b/internal/clients/baseclient.go @@ -114,9 +114,9 @@ func (c *baseClient) startConnection(ctx context.Context, i int, for { connCtx, cancel := context.WithCancel(ctx) - defer cancel() conn.Start(connCtx, cancel, c.throttleCh, c.stats.connectionsEstCh) + cancel() // Retrieve status code from handler (dtail client will exit with that status) status = conn.Handler().Status() -- cgit v1.2.3