From fc063aba4822e8e7d9ccc6c721fc2a711298e166 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Sun, 1 Mar 2026 17:35:16 +0200 Subject: Extract generate::safe_overwrite helper to eliminate DRY violation The "safe overwrite" pattern (diff -q tmp dest, then rm or mv) was duplicated in template, gemfeed (2x), and notes modules. Extracted into a shared helper with unit tests covering all three cases (no dest, identical dest, differing dest). Co-Authored-By: Claude Opus 4.6 --- lib/gemfeed.source.sh | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) (limited to 'lib/gemfeed.source.sh') diff --git a/lib/gemfeed.source.sh b/lib/gemfeed.source.sh index c405083..40792cc 100644 --- a/lib/gemfeed.source.sh +++ b/lib/gemfeed.source.sh @@ -20,11 +20,7 @@ gemfeed::updatemainindex () { "$gemfeed_dir/index.gmi" >> "$index_gmi.tmp" # Only overwrite if content changed, preserving mtime for template skip logic - if [[ -f "$index_gmi" ]] && diff -q "$index_gmi.tmp" "$index_gmi" >/dev/null 2>&1; then - rm "$index_gmi.tmp" - else - mv "$index_gmi.tmp" "$index_gmi" - fi + generate::safe_overwrite "$index_gmi.tmp" "$index_gmi" } gemfeed::_get_word_count () { @@ -65,11 +61,7 @@ GEMFEED done < <(gemfeed::get_posts) # Only overwrite if content changed, preserving mtime for template skip logic - if [[ -f "$gemfeed_dir/index.gmi" ]] && diff -q "$gemfeed_dir/index.gmi.tmp" "$gemfeed_dir/index.gmi" >/dev/null 2>&1; then - rm "$gemfeed_dir/index.gmi.tmp" - else - mv "$gemfeed_dir/index.gmi.tmp" "$gemfeed_dir/index.gmi" - fi + generate::safe_overwrite "$gemfeed_dir/index.gmi.tmp" "$gemfeed_dir/index.gmi" gemfeed::updatemainindex } -- cgit v1.2.3