fix(random): remove deprecated rand seeding (hq)

3 files changed, 24 insertions, 7 deletions

diff --git a/internal/cli/throttle.go b/internal/cli/throttle.go
index 5241782..3b85d10 100644
--- a/internal/cli/throttle.go
+++ b/internal/cli/throttle.go
@@ -162,8 +162,7 @@ func recordRepoSync(repoName string, st *state.State, throttle bool) {
 }
 
 func randomThrottleDuration() time.Duration {
-	rng := rand.New(rand.NewSource(time.Now().UnixNano()))
-	days := throttleMinDays + rng.Intn(throttleMaxDays-throttleMinDays+1)
+	days := throttleMinDays + rand.Intn(throttleMaxDays-throttleMinDays+1)
 	return time.Duration(days) * 24 * time.Hour
 }
 
diff --git a/internal/cli/throttle_test.go b/internal/cli/throttle_test.go
index 6833fe4..57ed8ba 100644
--- a/internal/cli/throttle_test.go
+++ b/internal/cli/throttle_test.go
@@ -106,3 +106,26 @@ func TestRecordRepoSync_SetsThrottleWindowWhenThrottleEnabled(t *testing.T) {
 		t.Fatalf("expected throttle window between %s and %s, got %s", minAllowed, maxAllowed, nextAllowed)
 	}
 }
+
+func TestRandomThrottleDuration_WithinBoundsAndNotDegenerate(t *testing.T) {
+	const draws = 200
+
+	seen := map[time.Duration]struct{}{}
+	minDuration := time.Duration(throttleMinDays) * 24 * time.Hour
+	maxDuration := time.Duration(throttleMaxDays) * 24 * time.Hour
+
+	for i := 0; i < draws; i++ {
+		d := randomThrottleDuration()
+		if d < minDuration || d > maxDuration {
+			t.Fatalf("expected duration between %s and %s, got %s", minDuration, maxDuration, d)
+		}
+		if d%(24*time.Hour) != 0 {
+			t.Fatalf("expected whole-day duration, got %s", d)
+		}
+		seen[d] = struct{}{}
+	}
+
+	if len(seen) < 2 {
+		t.Fatalf("expected at least 2 distinct durations across %d draws, got %d", draws, len(seen))
+	}
+}
diff --git a/internal/showcase/code_extractor.go b/internal/showcase/code_extractor.go
index fbf17f6..3b0e8bc 100644
--- a/internal/showcase/code_extractor.go
+++ b/internal/showcase/code_extractor.go
@@ -7,13 +7,8 @@ import (
 	"os"
 	"path/filepath"
 	"strings"
-	"time"
 )
 
-func init() {
-	rand.Seed(time.Now().UnixNano())
-}
-
 // extractCodeSnippet extracts a random code snippet from the repository
 func extractCodeSnippet(repoPath string, languages []LanguageStats) (string, string, error) {
 	if len(languages) == 0 {