From e637f4fbb06b1c0661d2e77ce79d0d5149ac5c47 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Tue, 24 Jun 2025 00:06:45 +0300
Subject: Ensure proper exit codes for all error conditions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Exit with code 1 when no action is specified (show usage)
- Remove redundant failedRepos tracking since we stop on first error
- Simplify code by removing unnecessary failure tracking arrays
- Add test script to verify exit code behavior
- All errors now consistently exit with code 1
- Successful operations exit with code 0

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
---
 test/test_exit_codes.sh | 65 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 65 insertions(+)
 create mode 100755 test/test_exit_codes.sh

(limited to 'test/test_exit_codes.sh')

diff --git a/test/test_exit_codes.sh b/test/test_exit_codes.sh
new file mode 100755
index 0000000..742e2ed
--- /dev/null
+++ b/test/test_exit_codes.sh
@@ -0,0 +1,65 @@
+#!/bin/bash
+
+# Test script to verify gitsyncer exit codes
+echo "Testing gitsyncer exit codes..."
+
+GITSYNCER="../gitsyncer"
+
+# Test 1: Successful operation should exit 0
+echo -n "Test 1 - Successful operation (--version): "
+$GITSYNCER --version >/dev/null 2>&1
+if [ $? -eq 0 ]; then
+    echo "PASS (exit code 0)"
+else
+    echo "FAIL (expected 0, got $?)"
+fi
+
+# Test 2: No arguments should exit 1
+echo -n "Test 2 - No arguments (show usage): "
+$GITSYNCER >/dev/null 2>&1
+if [ $? -eq 1 ]; then
+    echo "PASS (exit code 1)"
+else
+    echo "FAIL (expected 1, got $?)"
+fi
+
+# Test 3: Invalid config file should exit 1
+echo -n "Test 3 - Invalid config file: "
+$GITSYNCER --config /nonexistent/config.json --list-orgs >/dev/null 2>&1
+if [ $? -eq 1 ]; then
+    echo "PASS (exit code 1)"
+else
+    echo "FAIL (expected 1, got $?)"
+fi
+
+# Test 4: Sync non-existent repo should exit 1
+echo -n "Test 4 - Sync non-existent repo: "
+$GITSYNCER --sync nonexistentrepo123456 >/dev/null 2>&1
+if [ $? -eq 1 ]; then
+    echo "PASS (exit code 1)"
+else
+    echo "FAIL (expected 1, got $?)"
+fi
+
+# Test 5: Successful list operation should exit 0
+echo -n "Test 5 - Successful list operation: "
+$GITSYNCER --list-orgs >/dev/null 2>&1
+if [ $? -eq 0 ]; then
+    echo "PASS (exit code 0)"
+else
+    echo "FAIL (expected 0, got $?)"
+fi
+
+# Test 6: Test GitHub token without token should exit 1
+echo -n "Test 6 - Test GitHub token (invalid): "
+GITHUB_TOKEN="invalid" $GITSYNCER --test-github-token >/dev/null 2>&1
+if [ $? -eq 1 ]; then
+    echo "PASS (exit code 1)"
+else
+    echo "FAIL (expected 1, got $?)"
+fi
+
+echo ""
+echo "Summary: Exit codes are used correctly"
+echo "- Exit 0: Successful operations"
+echo "- Exit 1: Errors and invalid usage"
\ No newline at end of file
-- 
cgit v1.2.3