summaryrefslogtreecommitdiff
path: root/internal/cli/release_test.go
blob: 5712530b0b6f69848a9a23b6dd2daa8a5c1b8332 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
package cli

import (
	"errors"
	"testing"

	"codeberg.org/snonux/gitsyncer/internal/config"
	"codeberg.org/snonux/gitsyncer/internal/release"
)

type fakeReleaseNotesGenerator struct {
	aiNotes       string
	aiErr         error
	standardNotes string
	aiCalls       int
	standardCalls int
}

func (f *fakeReleaseNotesGenerator) GenerateAIReleaseNotes(_ string, _ string, _ string, _ []string, _ []string) (string, error) {
	f.aiCalls++
	if f.aiErr != nil {
		return "", f.aiErr
	}
	return f.aiNotes, nil
}

func (f *fakeReleaseNotesGenerator) GenerateReleaseNotes(_ string, _ string, _ []string) string {
	f.standardCalls++
	return f.standardNotes
}

func TestResolveReleaseNotes_CreateWithoutAIUsesStandardNotes(t *testing.T) {
	gen := &fakeReleaseNotesGenerator{standardNotes: "standard notes"}
	flags := &Flags{AIReleaseNotes: false}
	cache := map[string]string{}
	failed := []string{}
	saveCalls := 0

	notes, ok := resolveReleaseNotes(
		gen,
		flags,
		"/tmp/repo",
		"demo",
		"v1.0.0",
		[]string{"v1.0.0"},
		nil,
		"/tmp/cache.json",
		cache,
		&failed,
		"owner/demo:v1.0.0",
		releaseNotesModeCreate,
		func(_ string, _ map[string]string) error {
			saveCalls++
			return nil
		},
	)

	if !ok {
		t.Fatalf("expected ok=true")
	}
	if notes != "standard notes" {
		t.Fatalf("expected standard notes, got %q", notes)
	}
	if gen.standardCalls != 1 {
		t.Fatalf("expected standard generator to be called once, got %d", gen.standardCalls)
	}
	if gen.aiCalls != 0 {
		t.Fatalf("expected AI generator to not be called, got %d", gen.aiCalls)
	}
	if saveCalls != 0 {
		t.Fatalf("expected cache save to not be called, got %d", saveCalls)
	}
}

func TestResolveReleaseNotes_CreateUsesCachedAINotes(t *testing.T) {
	gen := &fakeReleaseNotesGenerator{aiNotes: "new ai notes"}
	flags := &Flags{AIReleaseNotes: true}
	cache := map[string]string{"demo:v1.0.0": "cached ai notes"}
	failed := []string{}

	notes, ok := resolveReleaseNotes(
		gen,
		flags,
		"/tmp/repo",
		"demo",
		"v1.0.0",
		[]string{"v1.0.0"},
		nil,
		"/tmp/cache.json",
		cache,
		&failed,
		"owner/demo:v1.0.0",
		releaseNotesModeCreate,
		func(_ string, _ map[string]string) error { return nil },
	)

	if !ok {
		t.Fatalf("expected ok=true")
	}
	if notes != "cached ai notes" {
		t.Fatalf("expected cached notes, got %q", notes)
	}
	if gen.aiCalls != 0 {
		t.Fatalf("expected AI generator to not be called when cached, got %d", gen.aiCalls)
	}
}

func TestResolveReleaseNotes_CreateAIFailureFallsBackAndClearsCache(t *testing.T) {
	gen := &fakeReleaseNotesGenerator{
		aiErr:         errors.New("ai unavailable"),
		standardNotes: "fallback notes",
	}
	flags := &Flags{AIReleaseNotes: true, Force: true}
	cache := map[string]string{"demo:v1.0.0": "stale"}
	failed := []string{}
	saveCalls := 0

	notes, ok := resolveReleaseNotes(
		gen,
		flags,
		"/tmp/repo",
		"demo",
		"v1.0.0",
		[]string{"v1.0.0"},
		nil,
		"/tmp/cache.json",
		cache,
		&failed,
		"owner/demo:v1.0.0",
		releaseNotesModeCreate,
		func(_ string, _ map[string]string) error {
			saveCalls++
			return nil
		},
	)

	if !ok {
		t.Fatalf("expected ok=true on create fallback")
	}
	if notes != "fallback notes" {
		t.Fatalf("expected fallback notes, got %q", notes)
	}
	if _, exists := cache["demo:v1.0.0"]; exists {
		t.Fatalf("expected cache entry to be removed after AI failure")
	}
	if len(failed) != 1 || failed[0] != "owner/demo:v1.0.0" {
		t.Fatalf("unexpected failed list: %#v", failed)
	}
	if saveCalls != 1 {
		t.Fatalf("expected cache save once after clearing entry, got %d", saveCalls)
	}
}

func TestResolveReleaseNotes_UpdateAIFailureSkipsUpdate(t *testing.T) {
	gen := &fakeReleaseNotesGenerator{
		aiErr:         errors.New("ai unavailable"),
		standardNotes: "unused fallback",
	}
	flags := &Flags{AIReleaseNotes: true, Force: true}
	cache := map[string]string{"demo:v1.0.0": "stale"}
	failed := []string{}
	saveCalls := 0

	notes, ok := resolveReleaseNotes(
		gen,
		flags,
		"/tmp/repo",
		"demo",
		"v1.0.0",
		[]string{"v1.0.0"},
		nil,
		"/tmp/cache.json",
		cache,
		&failed,
		"owner/demo:v1.0.0",
		releaseNotesModeUpdate,
		func(_ string, _ map[string]string) error {
			saveCalls++
			return nil
		},
	)

	if ok {
		t.Fatalf("expected ok=false for update on AI failure")
	}
	if notes != "" {
		t.Fatalf("expected empty notes on update failure, got %q", notes)
	}
	if gen.standardCalls != 0 {
		t.Fatalf("did not expect standard fallback generation for update mode")
	}
	if _, exists := cache["demo:v1.0.0"]; exists {
		t.Fatalf("expected cache entry to be removed after AI failure")
	}
	if len(failed) != 1 || failed[0] != "owner/demo:v1.0.0" {
		t.Fatalf("unexpected failed list: %#v", failed)
	}
	if saveCalls != 1 {
		t.Fatalf("expected cache save once after clearing entry, got %d", saveCalls)
	}
}

func TestResolveReleaseNotes_CreateAISuccessContinuesOnCacheSaveError(t *testing.T) {
	gen := &fakeReleaseNotesGenerator{aiNotes: "generated ai notes"}
	flags := &Flags{AIReleaseNotes: true}
	cache := map[string]string{}
	failed := []string{}

	notes, ok := resolveReleaseNotes(
		gen,
		flags,
		"/tmp/repo",
		"demo",
		"v1.0.0",
		[]string{"v1.0.0"},
		nil,
		"/tmp/cache.json",
		cache,
		&failed,
		"owner/demo:v1.0.0",
		releaseNotesModeCreate,
		func(_ string, _ map[string]string) error {
			return errors.New("disk full")
		},
	)

	if !ok {
		t.Fatalf("expected ok=true on AI success")
	}
	if notes != "generated ai notes" {
		t.Fatalf("unexpected notes: %q", notes)
	}
	if cache["demo:v1.0.0"] != "generated ai notes" {
		t.Fatalf("expected successful AI notes to remain in cache")
	}
	if len(failed) != 0 {
		t.Fatalf("unexpected failed list: %#v", failed)
	}
}

func TestGetMissingReleasesForTarget_FiltersConfiguredSkips(t *testing.T) {
	cfg := &config.Config{
		SkipReleases: map[string][]string{
			"demo": {"v1.0.0"},
		},
	}
	releaseManager := release.NewManager("")
	target := releaseTarget{
		name:  "GitHub",
		owner: "owner",
		getReleases: func(_ string, _ string) ([]string, error) {
			return []string{"v0.9.0"}, nil
		},
	}

	missing := getMissingReleasesForTarget(cfg, releaseManager, target, "demo", []string{"v0.9.0", "v1.0.0", "v1.1.0"})

	if len(missing) != 1 || missing[0] != "v1.1.0" {
		t.Fatalf("expected only non-skipped missing release v1.1.0, got %#v", missing)
	}
}

func TestGetMissingReleasesForTarget_GetReleasesErrorReturnsNil(t *testing.T) {
	cfg := &config.Config{}
	releaseManager := release.NewManager("")
	target := releaseTarget{
		name:  "GitHub",
		owner: "owner",
		getReleases: func(_ string, _ string) ([]string, error) {
			return nil, errors.New("upstream unavailable")
		},
	}

	missing := getMissingReleasesForTarget(cfg, releaseManager, target, "demo", []string{"v1.0.0"})

	if missing != nil {
		t.Fatalf("expected nil missing releases on getReleases error, got %#v", missing)
	}
}

func TestProcessCreateReleasesForTarget_CreateErrorDoesNotStopOtherTags(t *testing.T) {
	cfg := &config.Config{}
	flags := &Flags{AutoCreateReleases: true}
	releaseManager := release.NewManager("")

	created := make([]string, 0, 2)
	target := releaseTarget{
		name:  "GitHub",
		owner: "owner",
		createRelease: func(_ string, _ string, tag string, _ string) error {
			created = append(created, tag)
			if tag == "v1.0.0" {
				return errors.New("create failed")
			}
			return nil
		},
	}

	processCreateReleasesForTarget(
		cfg,
		flags,
		releaseManager,
		target,
		"demo",
		"/definitely/not/a/repo",
		[]string{"v1.0.0", "v1.1.0"},
		[]string{"v1.0.0", "v1.1.0"},
		"/tmp/cache.json",
		map[string]string{},
		&[]string{},
	)

	if len(created) != 2 || created[0] != "v1.0.0" || created[1] != "v1.1.0" {
		t.Fatalf("expected both releases to be attempted despite first failure, got %#v", created)
	}
}

func TestProcessCreateReleasesForTarget_HonorsConfiguredSkip(t *testing.T) {
	cfg := &config.Config{
		SkipReleases: map[string][]string{
			"demo": {"v1.0.0"},
		},
	}
	flags := &Flags{AutoCreateReleases: true}
	releaseManager := release.NewManager("")
	created := make([]string, 0, 1)
	target := releaseTarget{
		name:  "Codeberg",
		owner: "owner",
		createRelease: func(_ string, _ string, tag string, _ string) error {
			created = append(created, tag)
			return nil
		},
	}

	processCreateReleasesForTarget(
		cfg,
		flags,
		releaseManager,
		target,
		"demo",
		"/definitely/not/a/repo",
		[]string{"v1.0.0", "v1.1.0"},
		[]string{"v1.0.0", "v1.1.0"},
		"/tmp/cache.json",
		map[string]string{},
		&[]string{},
	)

	if len(created) != 1 || created[0] != "v1.1.0" {
		t.Fatalf("expected only non-skipped release creation attempt, got %#v", created)
	}
}

func TestProcessUpdateReleasesForTarget_UsesCachedAIAndSkipsNonVersionTags(t *testing.T) {
	flags := &Flags{
		AIReleaseNotes:     true,
		AutoCreateReleases: true,
	}
	releaseManager := release.NewManager("")
	updated := make([]string, 0, 1)
	target := releaseTarget{
		name:  "GitHub",
		owner: "owner",
		getReleases: func(_ string, _ string) ([]string, error) {
			return []string{"latest", "v1.0.0"}, nil
		},
		updateRelease: func(_ string, _ string, tag string, notes string) error {
			if notes != "cached ai notes" {
				t.Fatalf("expected cached AI notes, got %q", notes)
			}
			updated = append(updated, tag)
			return nil
		},
	}

	processUpdateReleasesForTarget(
		flags,
		releaseManager,
		target,
		"demo",
		"/definitely/not/a/repo",
		[]string{"v1.0.0"},
		"/tmp/cache.json",
		map[string]string{"demo:v1.0.0": "cached ai notes"},
		&[]string{},
	)

	if len(updated) != 1 || updated[0] != "v1.0.0" {
		t.Fatalf("expected exactly one version tag update, got %#v", updated)
	}
}

func TestProcessUpdateReleasesForTarget_GetReleasesErrorSkipsUpdates(t *testing.T) {
	flags := &Flags{
		AIReleaseNotes:     true,
		AutoCreateReleases: true,
	}
	releaseManager := release.NewManager("")
	updateCalls := 0
	target := releaseTarget{
		name:  "Codeberg",
		owner: "owner",
		getReleases: func(_ string, _ string) ([]string, error) {
			return nil, errors.New("api error")
		},
		updateRelease: func(_ string, _ string, _ string, _ string) error {
			updateCalls++
			return nil
		},
	}

	processUpdateReleasesForTarget(
		flags,
		releaseManager,
		target,
		"demo",
		"/definitely/not/a/repo",
		[]string{"v1.0.0"},
		"/tmp/cache.json",
		map[string]string{"demo:v1.0.0": "cached ai notes"},
		&[]string{},
	)

	if updateCalls != 0 {
		t.Fatalf("expected no update attempts when getReleases fails, got %d", updateCalls)
	}
}