diff options
| author | Paul Buetow <paul@buetow.org> | 2024-11-03 13:13:18 +0200 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2024-11-03 13:13:18 +0200 |
| commit | fd43fe299047c1c993678a28cbb84418190060d6 (patch) | |
| tree | c55e8e0cc84f4cff5df36e26292d3b5ee25df67c /internal/platforms | |
| parent | e9d79ae783000f449b39023836023a93a8edc7b4 (diff) | |
better this way
Diffstat (limited to 'internal/platforms')
| -rw-r--r-- | internal/platforms/linkedin/preview.go | 2 | ||||
| -rw-r--r-- | internal/platforms/linkedin/preview_test.go | 9 |
2 files changed, 6 insertions, 5 deletions
diff --git a/internal/platforms/linkedin/preview.go b/internal/platforms/linkedin/preview.go index 87a8d3e..b2a180a 100644 --- a/internal/platforms/linkedin/preview.go +++ b/internal/platforms/linkedin/preview.go @@ -26,7 +26,7 @@ func NewPreview(ctx context.Context, urls []string) (preview, error) { return preview{}, nil } title, imageURL, err := extractFromURL(ctx, urls[0]) - if errors.Is(err, errNoTitleElementFound) || (err == nil && title == "") { + if errors.Is(err, errNoTitleElementFound) || title == "" { log.Println("Setting title to", urls[0]) title = urls[0] } diff --git a/internal/platforms/linkedin/preview_test.go b/internal/platforms/linkedin/preview_test.go index c782764..1df969b 100644 --- a/internal/platforms/linkedin/preview_test.go +++ b/internal/platforms/linkedin/preview_test.go @@ -6,10 +6,10 @@ import ( ) func TestPreviewExtract(t *testing.T) { - - expectedTitle := "Baz" - expectedImageURL := "https://free.beer:666/bar/foo.jpg" - mockHTML := strings.NewReader(` + var ( + expectedTitle = "Baz" + expectedImageURL = "https://free.beer:666/bar/foo.jpg" + mockHTML = strings.NewReader(` <!DOCTYPE html> <html> <head> @@ -20,6 +20,7 @@ func TestPreviewExtract(t *testing.T) { </body> </html> `) + ) title, imageURL, err := extract("https://free.beer:666/bar/", mockHTML) if err != nil { |