From bdcf87d33d73ad6b75c954e9b667ac084075746d Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Wed, 23 Oct 2024 23:09:55 +0300
Subject: fix error handling

---
 internal/entry/entry.go                 | 2 +-
 internal/oi/oi.go                       | 2 +-
 internal/platforms/linkedin/linkedin.go | 2 +-
 internal/queue/queue.go                 | 7 ++++---
 4 files changed, 7 insertions(+), 6 deletions(-)

(limited to 'internal')

diff --git a/internal/entry/entry.go b/internal/entry/entry.go
index 475c315..99f7ee3 100644
--- a/internal/entry/entry.go
+++ b/internal/entry/entry.go
@@ -78,7 +78,7 @@ func New(filePath string) (Entry, error) {
 
 func (e Entry) Content() (string, error) {
 	bytes, err := os.ReadFile(e.Path)
-	if err != err {
+	if err != nil {
 		return "", err
 	}
 	return strings.TrimSpace(string(bytes)), nil
diff --git a/internal/oi/oi.go b/internal/oi/oi.go
index 1f7de6d..8ee29d5 100644
--- a/internal/oi/oi.go
+++ b/internal/oi/oi.go
@@ -72,7 +72,7 @@ func ReadDir[T any](dir string, cb func(file os.DirEntry) (T, bool)) ([]T, error
 	var results []T
 
 	ch, err := ReadDirCh(dir, cb)
-	if err != err {
+	if err != nil {
 		return results, err
 	}
 
diff --git a/internal/platforms/linkedin/linkedin.go b/internal/platforms/linkedin/linkedin.go
index 8224913..5f222fa 100644
--- a/internal/platforms/linkedin/linkedin.go
+++ b/internal/platforms/linkedin/linkedin.go
@@ -35,7 +35,7 @@ func post(ctx context.Context, args config.Args, sizeLimit int, ent entry.Entry)
 		return nil
 	}
 	personID, accessToken, err := oauth2.LinkedInCreds(ctx, args)
-	if err != err {
+	if err != nil {
 		return err
 	}
 	content, err := ent.ContentWithLimit(sizeLimit)
diff --git a/internal/queue/queue.go b/internal/queue/queue.go
index 75e0d20..2f8c780 100644
--- a/internal/queue/queue.go
+++ b/internal/queue/queue.go
@@ -17,6 +17,7 @@ import (
 // Strictly, we only operate on .txt files, but we also accept .md as Obsidian creates only .md files.
 var validExtensions = []string{".txt", ".md"}
 
+// TODO: Red alert when there are no messages to schedule, or less than N
 func Run(args config.Args) error {
 	if err := queueEntries(args); err != nil {
 		return err
@@ -34,7 +35,7 @@ func queueEntries(args config.Args) error {
 		return filePath, slices.Contains(validExtensions, filepath.Ext(file.Name())) &&
 			file.Type().IsRegular()
 	})
-	if err != err {
+	if err != nil {
 		return err
 	}
 
@@ -61,7 +62,7 @@ func queuePlatforms(args config.Args) error {
 		filePath := filepath.Join(dbDir, file.Name())
 		return filePath, strings.HasSuffix(file.Name(), ".queued")
 	})
-	if err != err {
+	if err != nil {
 		return err
 	}
 
@@ -122,7 +123,7 @@ func deleteFiles(path, suffix string, olderThan time.Time) error {
 		filePath := filepath.Join(path, file.Name())
 		return filePath, strings.HasSuffix(filePath, suffix) && file.Type().IsRegular()
 	})
-	if err != err {
+	if err != nil {
 		return err
 	}
 
-- 
cgit v1.2.3