From a3d3b676796f93f41f5b44b1d2b86b15f99080a0 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Wed, 25 Mar 2026 17:57:54 +0200
Subject: Fix Ln operation and add comprehensive tests
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Fixed Ln operation to handle Value conversion before math.Log using Float64() which handles boolean conversion (true → 1, false → 0)

- Added TestLnWithBoolean and TestLnEdgeCases tests for comprehensive coverage

- Refactored operations.go into separate files (arithmetic.go, boolean_ops.go, hyper.go, stack.go, variable.go)

- Removed unused toNumber function from number.go

- Added Float64() method to Value struct for boolean conversion
---
 internal/rpn/stack.go | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 68 insertions(+)
 create mode 100644 internal/rpn/stack.go

(limited to 'internal/rpn/stack.go')

diff --git a/internal/rpn/stack.go b/internal/rpn/stack.go
new file mode 100644
index 0000000..a956902
--- /dev/null
+++ b/internal/rpn/stack.go
@@ -0,0 +1,68 @@
+// SPDX-License-Identifier: MIT
+// Copyright (c) 2026 Paul Buetow
+
+package rpn
+
+import (
+	"fmt"
+)
+
+// StackOperations provides stack manipulation operator implementations.
+type StackOperations struct {
+}
+
+// NewStackOperations creates a new StackOperations instance.
+func NewStackOperations() *StackOperations {
+	return &StackOperations{}
+}
+
+// Dup duplicates the top stack value.
+func (o *StackOperations) Dup(stack *Stack) error {
+	val, err := stack.Peek()
+	if err != nil {
+		return fmt.Errorf("insufficient operands for dup: %w", err)
+	}
+	stack.Push(val)
+	return nil
+}
+
+// Swap swaps the top two stack values.
+func (o *StackOperations) Swap(stack *Stack) error {
+	b, err := stack.Pop()
+	if err != nil {
+		return fmt.Errorf("insufficient operands for swap: %w", err)
+	}
+
+	a, err := stack.Pop()
+	if err != nil {
+		return fmt.Errorf("insufficient operands for swap: %w", err)
+	}
+
+	// Push in swapped order
+	stack.Push(b)
+	stack.Push(a)
+	return nil
+}
+
+// Pop removes the top stack value.
+func (o *StackOperations) Pop(stack *Stack) error {
+	_, err := stack.Pop()
+	if err != nil {
+		return fmt.Errorf("insufficient operands for pop: %w", err)
+	}
+	return nil
+}
+
+// Show returns the current stack state as a string without modifying it.
+func (o *StackOperations) Show(stack *Stack) (string, error) {
+	if stack.Len() == 0 {
+		return "", fmt.Errorf("empty stack")
+	}
+	// For now, just return the top value as a string
+	// In a full implementation, this would show the entire stack
+	val, err := stack.Peek()
+	if err != nil {
+		return "", err
+	}
+	return val.String(), nil
+}
-- 
cgit v1.2.3