Add per-surface provider overrides and wiring

1 files changed, 51 insertions, 23 deletions

diff --git a/internal/appconfig/config_env_model_test.go b/internal/appconfig/config_env_model_test.go
index 2db2bb5..f34416d 100644
--- a/internal/appconfig/config_env_model_test.go
+++ b/internal/appconfig/config_env_model_test.go
@@ -1,37 +1,65 @@
 package appconfig
 
 import (
-    "log"
-    "os"
-    "testing"
+	"log"
+	"os"
+	"testing"
 )
 
 // Test that HEXAI_MODEL applies to provider model fields and that
 // provider-specific envs take precedence when both are set.
 func TestEnv_GenericModelOverrideAndPrecedence(t *testing.T) {
-    t.Setenv("HEXAI_MODEL", "gpt-5-codex")
-    t.Setenv("HEXAI_PROVIDER", "openai")
-    // No provider-specific env set yet: HEXAI_MODEL should flow into OpenAIModel
-    cfg := Load(log.New(os.Stderr, "test ", 0))
-    if cfg.OpenAIModel != "gpt-5-codex" {
-        t.Fatalf("expected OpenAIModel=gpt-5-codex via HEXAI_MODEL, got %q", cfg.OpenAIModel)
-    }
+	t.Setenv("HEXAI_MODEL", "gpt-5-codex")
+	t.Setenv("HEXAI_PROVIDER", "openai")
+	// No provider-specific env set yet: HEXAI_MODEL should flow into OpenAIModel
+	cfg := Load(log.New(os.Stderr, "test ", 0))
+	if cfg.OpenAIModel != "gpt-5-codex" {
+		t.Fatalf("expected OpenAIModel=gpt-5-codex via HEXAI_MODEL, got %q", cfg.OpenAIModel)
+	}
 
-    // Now set a provider-specific model; it should win over HEXAI_MODEL
-    t.Setenv("HEXAI_OPENAI_MODEL", "gpt-5-thinking")
-    cfg2 := Load(log.New(os.Stderr, "test ", 0))
-    if cfg2.OpenAIModel != "gpt-5-thinking" {
-        t.Fatalf("expected OpenAIModel from HEXAI_OPENAI_MODEL to win, got %q", cfg2.OpenAIModel)
-    }
+	// Now set a provider-specific model; it should win over HEXAI_MODEL
+	t.Setenv("HEXAI_OPENAI_MODEL", "gpt-5-thinking")
+	cfg2 := Load(log.New(os.Stderr, "test ", 0))
+	if cfg2.OpenAIModel != "gpt-5-thinking" {
+		t.Fatalf("expected OpenAIModel from HEXAI_OPENAI_MODEL to win, got %q", cfg2.OpenAIModel)
+	}
 }
 
 // Test that HEXAI_MODEL_FORCE overrides provider-specific envs (used by CLI --model).
 func TestEnv_ModelForce_OverridesProviderSpecific(t *testing.T) {
-    t.Setenv("HEXAI_OPENAI_MODEL", "gpt-5-main")
-    t.Setenv("HEXAI_MODEL_FORCE", "gpt-5-codex")
-    t.Setenv("HEXAI_PROVIDER", "openai")
-    cfg := Load(log.New(os.Stderr, "test ", 0))
-    if cfg.OpenAIModel != "gpt-5-codex" {
-        t.Fatalf("expected OpenAIModel forced to gpt-5-codex, got %q", cfg.OpenAIModel)
-    }
+	t.Setenv("HEXAI_OPENAI_MODEL", "gpt-5-main")
+	t.Setenv("HEXAI_MODEL_FORCE", "gpt-5-codex")
+	t.Setenv("HEXAI_PROVIDER", "openai")
+	cfg := Load(log.New(os.Stderr, "test ", 0))
+	if cfg.OpenAIModel != "gpt-5-codex" {
+		t.Fatalf("expected OpenAIModel forced to gpt-5-codex, got %q", cfg.OpenAIModel)
+	}
+}
+
+func TestEnv_SurfaceModelOverrides(t *testing.T) {
+	t.Setenv("HEXAI_MODEL_COMPLETION", "gpt-c")
+	t.Setenv("HEXAI_TEMPERATURE_COMPLETION", "0.44")
+	t.Setenv("HEXAI_PROVIDER_COMPLETION", "copilot")
+	t.Setenv("HEXAI_MODEL_CLI", "gpt-cli")
+	t.Setenv("HEXAI_TEMPERATURE_CLI", "0.22")
+	t.Setenv("HEXAI_PROVIDER_CLI", "ollama")
+	cfg := Load(log.New(os.Stderr, "test ", 0))
+	if cfg.CompletionModel != "gpt-c" {
+		t.Fatalf("expected completion model override, got %q", cfg.CompletionModel)
+	}
+	if cfg.CompletionTemperature == nil || *cfg.CompletionTemperature != 0.44 {
+		t.Fatalf("expected completion temperature override, got %v", cfg.CompletionTemperature)
+	}
+	if cfg.CompletionProvider != "copilot" {
+		t.Fatalf("expected completion provider override, got %q", cfg.CompletionProvider)
+	}
+	if cfg.CLIModel != "gpt-cli" {
+		t.Fatalf("expected cli model override, got %q", cfg.CLIModel)
+	}
+	if cfg.CLITemperature == nil || *cfg.CLITemperature != 0.22 {
+		t.Fatalf("expected cli temperature override, got %v", cfg.CLITemperature)
+	}
+	if cfg.CLIProvider != "ollama" {
+		t.Fatalf("expected cli provider override, got %q", cfg.CLIProvider)
+	}
 }