summaryrefslogtreecommitdiff
path: root/internal/hexaicli/run_output_test.go
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-06-11 00:28:27 +0300
committerPaul Buetow <paul@buetow.org>2026-06-11 00:28:27 +0300
commitb4f06c656d8d8733a9bf2e2e2a5eb2a7a48389bb (patch)
tree7df0eac26ded2b4854225711dfde8f40d80a0400 /internal/hexaicli/run_output_test.go
parent2b2f4110da53a03742faff89cdec17c55e091a90 (diff)
Extract shared chatrun package to eliminate chat-runner DRY violations
The CLI, LSP server and tmux code-action tool each carried near-identical chat-running logic: invoking the LLM (streaming-aware), collecting the response, and accounting sent/received bytes into the stats package. Introduce internal/chatrun with: - Invoke: streaming-aware LLM call that collects the full response and optionally mirrors chunks to a writer (nil writer = collect only). - SentBytes / Account: shared byte counting and stats.Update. Wire all three surfaces to it: - hexaicli: runChatRequest delegates to chatrun.Invoke; summarizeChatRun uses chatrun.Account. Removed the duplicated streaming/simple helpers. - hexaiaction: runOnce uses chatrun.Invoke + chatrun.Account, keeping the tmux status update local. - lsp: chatWithStats and the completion path use chatrun.SentBytes/Invoke; extracted unavailableClientError to keep chatWithStats small. chatrun has 100% test coverage; full suite passes with -race. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'internal/hexaicli/run_output_test.go')
-rw-r--r--internal/hexaicli/run_output_test.go8
1 files changed, 4 insertions, 4 deletions
diff --git a/internal/hexaicli/run_output_test.go b/internal/hexaicli/run_output_test.go
index e61e4b6..07a2cab 100644
--- a/internal/hexaicli/run_output_test.go
+++ b/internal/hexaicli/run_output_test.go
@@ -227,7 +227,7 @@ func TestRunStreamingChat_StreamError(t *testing.T) {
streamErr: fmt.Errorf("stream broken"),
}
var out bytes.Buffer
- _, err := runStreamingChat(context.Background(), client, nil, nil, &out)
+ _, err := runChatRequest(context.Background(), client, requestArgs{}, nil, &out)
if err == nil || !strings.Contains(err.Error(), "stream broken") {
t.Fatalf("expected stream error, got %v", err)
}
@@ -247,7 +247,7 @@ func (s *streamWriteErrClient) ChatStream(_ context.Context, _ []llm.Message, on
func TestRunStreamingChat_WriteError(t *testing.T) {
client := &streamWriteErrClient{fakeClient: fakeClient{name: "p", model: "m"}}
w := errWriter{err: errors.New("write fail")}
- _, err := runStreamingChat(context.Background(), client, nil, nil, w)
+ _, err := runChatRequest(context.Background(), client, requestArgs{}, nil, w)
if err == nil || !strings.Contains(err.Error(), "write fail") {
t.Fatalf("expected write error, got %v", err)
}
@@ -298,7 +298,7 @@ func TestEffectiveModel_Whitespace(t *testing.T) {
func TestRunSimpleChat_WriteError(t *testing.T) {
client := &fakeClient{name: "p", model: "m", resp: "ok"}
w := errWriter{err: errors.New("write fail")}
- _, err := runSimpleChat(context.Background(), client, nil, nil, w)
+ _, err := runChatRequest(context.Background(), client, requestArgs{}, nil, w)
if err == nil || !strings.Contains(err.Error(), "write fail") {
t.Fatalf("expected write error, got %v", err)
}
@@ -448,7 +448,7 @@ func TestRunSimpleChat_ChatError(t *testing.T) {
chatErr: fmt.Errorf("chat broken"),
}
var out bytes.Buffer
- _, err := runSimpleChat(context.Background(), client, nil, nil, &out)
+ _, err := runChatRequest(context.Background(), client, requestArgs{}, nil, &out)
if err == nil || !strings.Contains(err.Error(), "chat broken") {
t.Fatalf("expected chat error, got %v", err)
}