diff options
| author | Paul Buetow <paul@buetow.org> | 2026-03-16 04:33:36 +0200 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-03-16 04:33:36 +0200 |
| commit | 95b0a9962861b2aef4a3e9538dd38608aca4bcfc (patch) | |
| tree | 534a8c0f2bff31e612a9b12ff4d911bbead61c0c /internal/lsp/debounce_throttle_more_test.go | |
| parent | f55a1e88ea5948582d0e5a33efea0c5d806e1f4b (diff) | |
Document lock ordering, fix test data races, correct stateMu guard
- Add doc comments clarifying Server.mu and completionState.stateMu are
independent (no ordering constraint).
- Fix test using wrong lock (s.mu instead of stateMu) for lastLLMCall.
- Replace time.Sleep polling in 7 tests with s.inflight.Wait() to
eliminate data races under -race.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Diffstat (limited to 'internal/lsp/debounce_throttle_more_test.go')
| -rw-r--r-- | internal/lsp/debounce_throttle_more_test.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/internal/lsp/debounce_throttle_more_test.go b/internal/lsp/debounce_throttle_more_test.go index 7657cab..22d1888 100644 --- a/internal/lsp/debounce_throttle_more_test.go +++ b/internal/lsp/debounce_throttle_more_test.go @@ -26,9 +26,9 @@ func TestWaitForThrottle_WaitsRoughlyInterval(t *testing.T) { cfg := s.cfg cfg.CompletionThrottleMs = 20 s.cfg = cfg - s.mu.Lock() + s.stateMu.Lock() s.lastLLMCall = time.Now() - s.mu.Unlock() + s.stateMu.Unlock() start := time.Now() if !s.waitForThrottle(context.Background()) { t.Fatalf("waitForThrottle returned false") |