feat(lsp): add coding_temperature knob and remove hardcoded temps\n\n- Add to app config and server options.\n- Use in LSP code actions and completions.\n- Default to provider temperature when not set.\n- Update README and config.json.example.

2 files changed, 36 insertions, 19 deletions

diff --git a/internal/lsp/handlers.go b/internal/lsp/handlers.go
index 7903c73..d21c5b3 100644
--- a/internal/lsp/handlers.go
+++ b/internal/lsp/handlers.go
@@ -93,7 +93,12 @@ func (s *Server) handleCodeAction(req Request) {
 		ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
 		defer cancel()
 		messages := []llm.Message{{Role: "system", Content: sys}, {Role: "user", Content: user}}
-		if text, err := s.llmClient.Chat(ctx, messages, llm.WithMaxTokens(s.maxTokens), llm.WithTemperature(0.1)); err == nil {
+        // Build request options from server settings
+        opts := []llm.RequestOption{llm.WithMaxTokens(s.maxTokens)}
+        if s.codingTemperature != nil {
+            opts = append(opts, llm.WithTemperature(*s.codingTemperature))
+        }
+        if text, err := s.llmClient.Chat(ctx, messages, opts...); err == nil {
 			out := strings.TrimSpace(text)
 			if out != "" {
 				edit := WorkspaceEdit{Changes: map[string][]TextEdit{p.TextDocument.URI: {{Range: p.Range, NewText: out}}}}
@@ -123,7 +128,11 @@ func (s *Server) handleCodeAction(req Request) {
 		ctx, cancel := context.WithTimeout(context.Background(), 12*time.Second)
 		defer cancel()
 		messages := []llm.Message{{Role: "system", Content: sys}, {Role: "user", Content: b.String()}}
-		if text, err := s.llmClient.Chat(ctx, messages, llm.WithMaxTokens(s.maxTokens), llm.WithTemperature(0.1)); err == nil {
+        opts := []llm.RequestOption{llm.WithMaxTokens(s.maxTokens)}
+        if s.codingTemperature != nil {
+            opts = append(opts, llm.WithTemperature(*s.codingTemperature))
+        }
+        if text, err := s.llmClient.Chat(ctx, messages, opts...); err == nil {
 			out := strings.TrimSpace(text)
 			if out != "" {
 				edit := WorkspaceEdit{Changes: map[string][]TextEdit{p.TextDocument.URI: {{Range: p.Range, NewText: out}}}}
@@ -454,7 +463,11 @@ func (s *Server) tryLLMCompletion(p CompletionParams, above, current, below, fun
 	s.llmSentBytesTotal += int64(sentSize)
 	s.mu.Unlock()
 
-	text, err := s.llmClient.Chat(ctx, messages, llm.WithMaxTokens(s.maxTokens), llm.WithTemperature(0.2))
+    opts := []llm.RequestOption{llm.WithMaxTokens(s.maxTokens)}
+    if s.codingTemperature != nil {
+        opts = append(opts, llm.WithTemperature(*s.codingTemperature))
+    }
+    text, err := s.llmClient.Chat(ctx, messages, opts...)
 	if err != nil {
 		logging.Logf("lsp ", "llm completion error: %v", err)
 		// Log updated averages after this request (even if failed)
diff --git a/internal/lsp/server.go b/internal/lsp/server.go
index 5f4423a..f1ca302 100644
--- a/internal/lsp/server.go
+++ b/internal/lsp/server.go
@@ -29,7 +29,9 @@ type Server struct {
 	windowLines      int
 	maxContextTokens int
 	noDiskIO         bool
-	triggerChars     []string
+    triggerChars     []string
+    // If set, used as the LSP coding temperature for all LLM calls
+    codingTemperature *float64
 	// LLM request stats
 	llmReqTotal       int64
 	llmSentBytesTotal int64
@@ -40,14 +42,15 @@ type Server struct {
 
 // ServerOptions collects configuration for NewServer to avoid long parameter lists.
 type ServerOptions struct {
-	LogContext        bool
-	MaxTokens         int
-	ContextMode       string
-	WindowLines       int
-	MaxContextTokens  int
-	
-	Client            llm.Client
-	TriggerCharacters []string
+    LogContext        bool
+    MaxTokens         int
+    ContextMode       string
+    WindowLines       int
+    MaxContextTokens  int
+
+    Client            llm.Client
+    TriggerCharacters []string
+    CodingTemperature *float64
 }
 
 func NewServer(r io.Reader, w io.Writer, logger *log.Logger, opts ServerOptions) *Server {
@@ -74,13 +77,14 @@ func NewServer(r io.Reader, w io.Writer, logger *log.Logger, opts ServerOptions)
 	s.maxContextTokens = maxContextTokens
 	
 	s.startTime = time.Now()
-	s.llmClient = opts.Client
-	if len(opts.TriggerCharacters) == 0 {
-		s.triggerChars = []string{".", ":", "/", "_", ";", "?"}
-	} else {
-		s.triggerChars = append([]string{}, opts.TriggerCharacters...)
-	}
-	return s
+    s.llmClient = opts.Client
+    if len(opts.TriggerCharacters) == 0 {
+        s.triggerChars = []string{".", ":", "/", "_", ";", "?"}
+    } else {
+        s.triggerChars = append([]string{}, opts.TriggerCharacters...)
+    }
+    s.codingTemperature = opts.CodingTemperature
+    return s
 }
 
 func (s *Server) Run() error {