diff options
| author | Paul Buetow <paul@buetow.org> | 2025-08-17 21:56:21 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2025-08-17 21:58:38 +0300 |
| commit | 562830b020aba76050c66f3115af7f6c88a87423 (patch) | |
| tree | 6683fb8ff36d88390815a12ee1c78b0069e94ce9 /internal | |
| parent | 8b790c35e0b78809cf32fd64eb25cc12bba48a0d (diff) | |
refactor: Remove unused NoDiskIO flag
This flag was not used anywhere in the codebase, so it has been removed.
Diffstat (limited to 'internal')
| -rw-r--r-- | internal/appconfig/config.go | 6 | ||||
| -rw-r--r-- | internal/hexailsp/run.go | 2 | ||||
| -rw-r--r-- | internal/hexailsp/run_test.go | 4 | ||||
| -rw-r--r-- | internal/lsp/server.go | 4 |
4 files changed, 7 insertions, 9 deletions
diff --git a/internal/appconfig/config.go b/internal/appconfig/config.go index 4b42ffc..00b32bd 100644 --- a/internal/appconfig/config.go +++ b/internal/appconfig/config.go @@ -18,7 +18,7 @@ type App struct { ContextWindowLines int `json:"context_window_lines"` MaxContextTokens int `json:"max_context_tokens"` LogPreviewLimit int `json:"log_preview_limit"` - NoDiskIO bool `json:"no_disk_io"` + TriggerCharacters []string `json:"trigger_characters"` Provider string `json:"provider"` @@ -40,7 +40,7 @@ func Load(logger *log.Logger) App { ContextWindowLines: 120, MaxContextTokens: 4000, LogPreviewLimit: 100, - NoDiskIO: true, + } if logger == nil { return cfg // Return defaults if no logger is provided (e.g. in tests) @@ -86,7 +86,7 @@ func Load(logger *log.Logger) App { if fileCfg.LogPreviewLimit >= 0 { cfg.LogPreviewLimit = fileCfg.LogPreviewLimit } - cfg.NoDiskIO = fileCfg.NoDiskIO + if len(fileCfg.TriggerCharacters) > 0 { cfg.TriggerCharacters = slices.Clone(fileCfg.TriggerCharacters) } diff --git a/internal/hexailsp/run.go b/internal/hexailsp/run.go index 2231fc2..5a0ab4a 100644 --- a/internal/hexailsp/run.go +++ b/internal/hexailsp/run.go @@ -80,7 +80,7 @@ func RunWithFactory(logPath string, stdin io.Reader, stdout io.Writer, logger *l ContextMode: cfg.ContextMode, WindowLines: cfg.ContextWindowLines, MaxContextTokens: cfg.MaxContextTokens, - NoDiskIO: cfg.NoDiskIO, + Client: client, TriggerCharacters: cfg.TriggerCharacters, }) diff --git a/internal/hexailsp/run_test.go b/internal/hexailsp/run_test.go index 923f408..7af9cb8 100644 --- a/internal/hexailsp/run_test.go +++ b/internal/hexailsp/run_test.go @@ -51,9 +51,7 @@ func TestRunWithFactory_UsesDefaultsAndCallsServer(t *testing.T) { if gotOpts.MaxContextTokens != cfg.MaxContextTokens { t.Fatalf("MaxContextTokens want %d got %d", cfg.MaxContextTokens, gotOpts.MaxContextTokens) } - if gotOpts.NoDiskIO != cfg.NoDiskIO { - t.Fatalf("NoDiskIO want %v got %v", cfg.NoDiskIO, gotOpts.NoDiskIO) - } + if gotOpts.Client != nil { // with no env, openai client fails to build t.Fatalf("expected nil client when API key missing") } diff --git a/internal/lsp/server.go b/internal/lsp/server.go index 9fb02c3..5f4423a 100644 --- a/internal/lsp/server.go +++ b/internal/lsp/server.go @@ -45,7 +45,7 @@ type ServerOptions struct { ContextMode string WindowLines int MaxContextTokens int - NoDiskIO bool + Client llm.Client TriggerCharacters []string } @@ -72,7 +72,7 @@ func NewServer(r io.Reader, w io.Writer, logger *log.Logger, opts ServerOptions) s.contextMode = contextMode s.windowLines = windowLines s.maxContextTokens = maxContextTokens - s.noDiskIO = opts.NoDiskIO + s.startTime = time.Now() s.llmClient = opts.Client if len(opts.TriggerCharacters) == 0 { |
