summaryrefslogtreecommitdiff
path: root/internal/llm
diff options
context:
space:
mode:
Diffstat (limited to 'internal/llm')
-rw-r--r--internal/llm/copilot_http_test.go25
-rw-r--r--internal/llm/openai_test.go112
-rw-r--r--internal/llm/test_helpers_test.go3
3 files changed, 90 insertions, 50 deletions
diff --git a/internal/llm/copilot_http_test.go b/internal/llm/copilot_http_test.go
index d66311c..9dd4aee 100644
--- a/internal/llm/copilot_http_test.go
+++ b/internal/llm/copilot_http_test.go
@@ -5,6 +5,7 @@ import (
"encoding/base64"
"encoding/json"
"io"
+ "net"
"net/http"
"net/http/httptest"
"os"
@@ -22,7 +23,7 @@ func TestCopilot_EnsureSession_AndChat_Success(t *testing.T) {
t.Skip("skip network-bound tests in restricted environments")
}
// Mock chat endpoint
- chatSrv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ chatSrv := newIPv4Server(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if r.URL.Path != "/chat/completions" {
t.Fatalf("unexpected path: %s", r.URL.Path)
}
@@ -92,7 +93,7 @@ func TestCopilot_Chat_MultiChoice_And_ErrorBody(t *testing.T) {
t.Skip("skip network-bound tests in restricted environments")
}
// Chat multi-choice: return two choices; client returns first content
- srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ srv := newIPv4Server(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
_ = json.NewEncoder(w).Encode(map[string]any{
"choices": []map[string]any{
{"index": 0, "finish_reason": "stop", "message": map[string]string{"role": "assistant", "content": "FIRST"}},
@@ -120,7 +121,7 @@ func TestCopilot_Chat_MultiChoice_And_ErrorBody(t *testing.T) {
}
// Non-2xx with error body
- srv2 := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ srv2 := newIPv4Server(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
w.WriteHeader(403)
_ = json.NewEncoder(w).Encode(map[string]any{"error": map[string]any{"message": "denied", "type": "forbidden"}})
}))
@@ -136,7 +137,7 @@ func TestCopilot_Chat_NoChoices_Error(t *testing.T) {
if os.Getenv("HEXAI_TEST_SKIP_NET") == "1" {
t.Skip("skip network-bound tests in restricted environments")
}
- srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ srv := newIPv4Server(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
_ = json.NewEncoder(w).Encode(map[string]any{"choices": []any{}})
}))
defer srv.Close()
@@ -162,7 +163,7 @@ func TestCopilot_Chat_DecodeError_StatusOK(t *testing.T) {
t.Skip("skip network-bound tests in restricted environments")
}
// Chat returns 200 but invalid JSON; expect decode error
- srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ srv := newIPv4Server(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
io.WriteString(w, "{invalid")
}))
defer srv.Close()
@@ -254,6 +255,20 @@ func TestParseJWTExp_AndParseInt64(t *testing.T) {
}
}
+func newIPv4Server(t *testing.T, handler http.Handler) *httptest.Server {
+ t.Helper()
+ l, err := net.Listen("tcp4", "127.0.0.1:0")
+ if err != nil {
+ t.Fatalf("failed to listen on tcp4: %v", err)
+ }
+ srv := &httptest.Server{
+ Listener: l,
+ Config: &http.Server{Handler: handler},
+ }
+ srv.Start()
+ return srv
+}
+
// bytesReader wraps a byte slice with an io.ReadCloser without importing extra.
type bytesReader []byte
diff --git a/internal/llm/openai_test.go b/internal/llm/openai_test.go
index f7ce080..686d535 100644
--- a/internal/llm/openai_test.go
+++ b/internal/llm/openai_test.go
@@ -1,67 +1,89 @@
package llm
import (
- "bytes"
- "encoding/json"
+ "context"
"io"
"net/http"
"strings"
"testing"
- "time"
+
+ "codeberg.org/snonux/hexai/internal/logging"
)
-func f64p(v float64) *float64 { return &v }
+func TestOpenAIChatSuccess(t *testing.T) {
+ transport := roundTripFunc(func(r *http.Request) (*http.Response, error) {
+ if r.URL.Path != "/chat/completions" {
+ t.Fatalf("unexpected path: %s", r.URL.Path)
+ }
+ if got := r.Header.Get("Authorization"); got != "Bearer test-key" {
+ t.Fatalf("expected auth header, got %q", got)
+ }
+ return &http.Response{
+ StatusCode: 200,
+ Body: io.NopCloser(strings.NewReader(`{"choices":[{"index":0,"message":{"role":"assistant","content":"hi there"},"finish_reason":"stop"}]}`)),
+ Header: make(http.Header),
+ }, nil
+ })
-func TestBuildOAChatRequest_TempFallbackAndFields(t *testing.T) {
- o := Options{Model: "m1", Temperature: 0, MaxTokens: 42, Stop: []string{"END"}}
- msgs := []Message{{Role: "user", Content: "hi"}}
- req := buildOAChatRequest(o, msgs, f64p(0.3), false)
- if req.Model != "m1" || req.Stream {
- t.Fatalf("model/stream mismatch: %+v", req)
- }
- if req.Temperature == nil || *req.Temperature != 0.3 {
- t.Fatalf("expected default temp 0.3, got %#v", req.Temperature)
- }
- if req.MaxTokens == nil || *req.MaxTokens != 42 {
- t.Fatalf("expected max tokens 42")
+ client := openAIClient{
+ httpClient: &http.Client{Transport: transport},
+ apiKey: "test-key",
+ baseURL: "https://example.com",
+ defaultModel: "gpt-test",
+ chatLogger: logging.NewChatLogger("openai"),
}
- if len(req.Stop) != 1 || req.Stop[0] != "END" {
- t.Fatalf("stop not propagated: %#v", req.Stop)
+
+ out, err := client.Chat(context.Background(), []Message{{Role: "user", Content: "hello"}})
+ if err != nil {
+ t.Fatalf("Chat returned error: %v", err)
}
- if len(req.Messages) != 1 || req.Messages[0].Content != "hi" {
- t.Fatalf("messages not copied")
+ if out != "hi there" {
+ t.Fatalf("unexpected chat output: %q", out)
}
+}
- // stream on
- req2 := buildOAChatRequest(o, msgs, f64p(0.3), true)
- if !req2.Stream {
- t.Fatalf("expected stream=true")
+func TestOpenAIChatStreamDeliversChunks(t *testing.T) {
+ client := openAIClient{
+ httpClient: &http.Client{Transport: roundTripFunc(func(r *http.Request) (*http.Response, error) {
+ body := "data: {\"choices\":[{\"delta\":{\"content\":\"Hello\"}}]}\n" +
+ "data: {\"choices\":[{\"finish_reason\":\"stop\"}]}\n" +
+ "data: [DONE]\n"
+ return &http.Response{StatusCode: 200, Body: io.NopCloser(strings.NewReader(body)), Header: make(http.Header)}, nil
+ })},
+ apiKey: "test-key",
+ baseURL: "https://example.com",
+ defaultModel: "gpt-test",
+ chatLogger: logging.NewChatLogger("openai"),
}
-}
-func TestHandleOpenAINon2xx_WithAPIError(t *testing.T) {
- api := oaChatResponse{Error: &struct {
- Message string `json:"message"`
- Type string `json:"type"`
- Param any `json:"param"`
- Code any `json:"code"`
- }{Message: "bad", Type: "invalid"}}
- b, _ := json.Marshal(api)
- resp := &http.Response{StatusCode: 400, Body: io.NopCloser(bytes.NewReader(b))}
- if err := handleOpenAINon2xx(resp, time.Now()); err == nil {
- t.Fatalf("expected error for non-2xx with body")
+ var received string
+ err := client.ChatStream(context.Background(), []Message{{Role: "user", Content: "hello"}}, func(chunk string) {
+ received += chunk
+ })
+ if err != nil {
+ t.Fatalf("ChatStream returned error: %v", err)
+ }
+ if received != "Hello" {
+ t.Fatalf("expected streamed content, got %q", received)
}
}
-func TestParseOpenAIStream_DeliversChunks(t *testing.T) {
- stream := "data: {\"choices\":[{\"delta\":{\"content\":\"Hi\"}}]}\n\n" +
- "data: [DONE]\n"
- resp := &http.Response{Body: io.NopCloser(strings.NewReader(stream))}
- var got strings.Builder
- if err := parseOpenAIStream(resp, time.Now(), func(s string) { got.WriteString(s) }); err != nil {
- t.Fatalf("unexpected error: %v", err)
+func TestOpenAIChatHandlesNon2xx(t *testing.T) {
+ client := openAIClient{
+ httpClient: &http.Client{Transport: roundTripFunc(func(r *http.Request) (*http.Response, error) {
+ return &http.Response{StatusCode: http.StatusUnauthorized, Body: io.NopCloser(strings.NewReader("denied")), Header: make(http.Header)}, nil
+ })},
+ apiKey: "test-key",
+ baseURL: "https://example.com",
+ defaultModel: "gpt-test",
+ chatLogger: logging.NewChatLogger("openai"),
}
- if got.String() != "Hi" {
- t.Fatalf("got %q want %q", got.String(), "Hi")
+
+ if _, err := client.Chat(context.Background(), []Message{{Role: "user", Content: "hi"}}); err == nil {
+ t.Fatal("expected error for non-2xx response")
}
}
+
+type roundTripFunc func(*http.Request) (*http.Response, error)
+
+func (f roundTripFunc) RoundTrip(r *http.Request) (*http.Response, error) { return f(r) }
diff --git a/internal/llm/test_helpers_test.go b/internal/llm/test_helpers_test.go
new file mode 100644
index 0000000..051747a
--- /dev/null
+++ b/internal/llm/test_helpers_test.go
@@ -0,0 +1,3 @@
+package llm
+
+func f64p(v float64) *float64 { return &v }
generated by cgit v1.2.3 (git 2.25.1) at 2026-06-15 01:21:31 +0000