From 426068b0ea1fff4e2bfc708d8a3914379f084ad8 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Fri, 19 Jun 2026 08:47:44 +0300 Subject: Fix MCP invalid JSON test race (4k0) --- internal/mcp/handlers_prompt_test.go | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/internal/mcp/handlers_prompt_test.go b/internal/mcp/handlers_prompt_test.go index d3f34e2..2ea52a1 100644 --- a/internal/mcp/handlers_prompt_test.go +++ b/internal/mcp/handlers_prompt_test.go @@ -875,10 +875,7 @@ func TestServer_Run_InvalidJSON(t *testing.T) { server := NewServer(inBuf, outBuf, logger, store, nil) // Write invalid JSON - msg := []byte(`{invalid json}`) - header := fmt.Sprintf("Content-Length: %d\r\n\r\n", len(msg)) - inBuf.WriteString(header) - inBuf.Write(msg) + inBuf.WriteString("{invalid json}\n") // Run in background done := make(chan error, 1) @@ -888,14 +885,27 @@ func TestServer_Run_InvalidJSON(t *testing.T) { // Wait for processing to complete select { - case <-done: + case err := <-done: + if err != nil { + t.Fatalf("Run() error = %v", err) + } case <-time.After(2 * time.Second): t.Fatal("server.Run(context.Background()) did not return in time") } - // Should have written error response - if outBuf.Len() == 0 { - t.Error("Expected error response to be written") + resp, err := readResponse(outBuf) + if err != nil { + t.Fatalf("readResponse() error = %v", err) + } + + if resp.Error == nil { + t.Fatal("Expected parse error response") + } + if resp.Error.Code != ErrCodeParseError { + t.Errorf("Error code = %d, want %d", resp.Error.Code, ErrCodeParseError) + } + if resp.Error.Message != "Parse error" { + t.Errorf("Error message = %q, want %q", resp.Error.Message, "Parse error") } } -- cgit v1.2.3