From c4b872c5ec54340b1e62d7578ace400340573ce2 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Sun, 26 Apr 2026 18:16:11 +0300
Subject: test: bring every package above the 80% coverage target

Per-package coverage was below the AGENTS.md target in six packages:

  cmd/ask                  0.0% -> 83.3%
  cmd/hexai-tmux-edit     10.0% -> 93.3%
  cmd/hexai-tmux-action   27.8% -> 95.7%
  cmd/hexai-mcp-server    41.9% -> 88.2%
  internal/taskproxy      61.8% -> 98.2%
  internal/filelock       77.3% -> 100.0%

The four cmd packages each had a main() that mixed flag parsing, struct
construction, and runtime delegation, so nothing called from a test
hit those statements. Each main() is now a one-line wrapper around a
testable runMain(args, stdin, stdout, stderr) int that uses
flag.NewFlagSet (instead of the global flag.Parse) so tests can drive
it repeatedly. The deprecation banner in hexai-mcp-server is now a
package-level constant, kept identical, so tests can assert on it
directly without redirecting os.Stderr.

The internal packages got new tests for paths that were previously
unreachable: filelock's retry-then-success and non-EWOULDBLOCK error
branches, and taskproxy's NewRunner / findTaskBinary / detectRepoRoot /
runTaskCommand helpers (the ones that shell out to git and task).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---
 cmd/ask/main_test.go | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

(limited to 'cmd/ask/main_test.go')

diff --git a/cmd/ask/main_test.go b/cmd/ask/main_test.go
index db6b436..643dde4 100644
--- a/cmd/ask/main_test.go
+++ b/cmd/ask/main_test.go
@@ -3,7 +3,9 @@ package main
 import (
 	"bytes"
 	"context"
+	"errors"
 	"io"
+	"strings"
 	"testing"
 
 	"codeberg.org/snonux/hexai/internal/askcli"
@@ -49,3 +51,70 @@ type spyRunner struct {
 func (s *spyRunner) Run(ctx context.Context, args []string, stdin io.Reader, stdout, stderr io.Writer) (int, error) {
 	return s.runFn(ctx, args, stdin, stdout, stderr)
 }
+
+// fakeDispatcher captures Dispatch arguments and returns canned values; used
+// to exercise runMain without a real Taskwarrior binary on PATH.
+type fakeDispatcher struct {
+	gotArgs []string
+	code    int
+	err     error
+}
+
+func (f *fakeDispatcher) Dispatch(_ context.Context, args []string, _ io.Reader, _, _ io.Writer) (int, error) {
+	f.gotArgs = append([]string(nil), args...)
+	return f.code, f.err
+}
+
+// Driving runMain through a fake dispatcher proves the wiring (args
+// forwarded, exit code returned) without touching the real ask CLI.
+func TestRunMain_DelegatesAndReturnsCode(t *testing.T) {
+	old := dispatcherFactory
+	t.Cleanup(func() { dispatcherFactory = old })
+
+	fake := &fakeDispatcher{code: 0}
+	dispatcherFactory = func() dispatcher { return fake }
+
+	var stdout, stderr bytes.Buffer
+	got := runMain([]string{"list", "limit:1"}, nil, &stdout, &stderr)
+	if got != 0 {
+		t.Fatalf("runMain code = %d, want 0", got)
+	}
+	if len(fake.gotArgs) != 2 || fake.gotArgs[0] != "list" || fake.gotArgs[1] != "limit:1" {
+		t.Fatalf("Dispatch args = %v", fake.gotArgs)
+	}
+	if stderr.Len() != 0 {
+		t.Fatalf("stderr should be empty on success, got %q", stderr.String())
+	}
+}
+
+// The default dispatcherFactory must return a working real dispatcher (this
+// is the path main() uses in production); fakes used elsewhere don't cover
+// it, so verify it explicitly.
+func TestDispatcherFactory_DefaultReturnsRealDispatcher(t *testing.T) {
+	d := dispatcherFactory()
+	if d == nil {
+		t.Fatal("default dispatcherFactory returned nil")
+	}
+	if _, ok := d.(*askcli.Dispatcher); !ok {
+		t.Fatalf("default dispatcherFactory returned %T, want *askcli.Dispatcher", d)
+	}
+}
+
+// On a dispatcher error, runMain must print the error to stderr AND surface
+// the dispatcher's exit code so the shell sees Taskwarrior's own status.
+func TestRunMain_PrintsErrorAndPropagatesExitCode(t *testing.T) {
+	old := dispatcherFactory
+	t.Cleanup(func() { dispatcherFactory = old })
+
+	fake := &fakeDispatcher{code: 7, err: errors.New("dispatch boom")}
+	dispatcherFactory = func() dispatcher { return fake }
+
+	var stdout, stderr bytes.Buffer
+	got := runMain(nil, nil, &stdout, &stderr)
+	if got != 7 {
+		t.Fatalf("runMain code = %d, want 7", got)
+	}
+	if !strings.Contains(stderr.String(), "dispatch boom") {
+		t.Fatalf("stderr missing error text: %q", stderr.String())
+	}
+}
-- 
cgit v1.2.3