From 1e2e96f92d6fb25ae55303d90444534369bda0aa Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Mon, 23 Mar 2026 08:21:27 +0200 Subject: fix: correct taskwarrior filter ordering in dep and info commands MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - command_dep.go handleDepAddRm: was passing uuid as a modification argument (task modify depends:...) which could modify ALL agent tasks; now uses uuid: as filter - command_dep.go handleDepList: updated deprecated 'uuid ' space syntax to canonical 'uuid:' colon syntax - command_info_add.go handleInfo: same space→colon fix for consistency All mutation commands now uniformly use uuid: as the filter before the action verb. Co-Authored-By: Claude Sonnet 4.6 --- internal/askcli/command_dep_test.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'internal/askcli/command_dep_test.go') diff --git a/internal/askcli/command_dep_test.go b/internal/askcli/command_dep_test.go index 26ddf08..b059dd8 100644 --- a/internal/askcli/command_dep_test.go +++ b/internal/askcli/command_dep_test.go @@ -9,7 +9,9 @@ import ( ) func TestHandleDep_AddSuccess(t *testing.T) { + var capturedArgs []string d := NewDispatcher(&spyRunner{runFn: func(ctx context.Context, args []string, stdin io.Reader, stdout, stderr io.Writer) (int, error) { + capturedArgs = args return 0, nil }}) var stdout, stderr bytes.Buffer @@ -20,6 +22,10 @@ func TestHandleDep_AddSuccess(t *testing.T) { if !strings.Contains(stdout.String(), "ok") || !strings.Contains(stdout.String(), "uuid-1") { t.Fatalf("stdout = %q, want ok + uuid", stdout.String()) } + // Verify uuid: is the filter (not a modification argument). + if len(capturedArgs) < 3 || capturedArgs[0] != "uuid:uuid-1" || capturedArgs[1] != "modify" { + t.Fatalf("capturedArgs = %v, want [uuid:uuid-1, modify, depends:uuid-2]", capturedArgs) + } } func TestHandleDep_RmSuccess(t *testing.T) { -- cgit v1.2.3