From 3ea11bc5d671d962d01b57fa0fba0bda611025fe Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Mon, 23 Mar 2026 08:27:18 +0200
Subject: fix: code quality improvements across lsp, askcli, appconfig,
 integrationtests

- lsp/handlers_completion.go: track collectFirstCompletion goroutine in
  inflight WaitGroup (goroutine leak fix)
- lsp/transport.go: use %w instead of %v for error wrapping
- askcli/command_list.go: extract handleListWithFilters shared helper;
  handleList/handleAll/handleReady are now single-liners
- askcli/command_list.go, urgency.go, dep.go: log ParseTaskExport errors
  to stderr instead of returning 1 silently
- appconfig/config_load.go: rename 'any' variable to 'found' to avoid
  shadowing the built-in identifier
- llm/provider.go: add explanatory comment for package-level registry
- integrationtests/ask_test.go: add //go:build integration tag; move
  repoRoot init from init() to TestMain with diagnostic error message

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 internal/askcli/command_list.go | 69 ++++++++---------------------------------
 1 file changed, 13 insertions(+), 56 deletions(-)

(limited to 'internal/askcli/command_list.go')

diff --git a/internal/askcli/command_list.go b/internal/askcli/command_list.go
index 64ec2fb..54eaafc 100644
--- a/internal/askcli/command_list.go
+++ b/internal/askcli/command_list.go
@@ -3,74 +3,30 @@ package askcli
 import (
 	"bytes"
 	"context"
+	"fmt"
 	"io"
 	"sort"
 	"strings"
 )
 
 func (d Dispatcher) handleList(ctx context.Context, args []string, stdout, stderr io.Writer) (int, error) {
-	filterArgs := []string{"status:pending"}
-	for _, arg := range args[1:] {
-		if strings.HasPrefix(arg, "limit:") || strings.HasPrefix(arg, "sort:") ||
-			strings.HasPrefix(arg, "+") || arg == "started" {
-			filterArgs = append(filterArgs, arg)
-		}
-	}
-	filterArgs = append(filterArgs, "export")
-	var outBuf bytes.Buffer
-	code, err := d.runner.Run(ctx, filterArgs, nil, &outBuf, stderr)
-	if code != 0 {
-		return code, err
-	}
-	tasks, err := ParseTaskExport(&outBuf)
-	if err != nil {
-		return 1, nil
-	}
-	sort.Slice(tasks, func(i, j int) bool {
-		pi := priorityOrder(tasks[i].Priority)
-		pj := priorityOrder(tasks[j].Priority)
-		if pi != pj {
-			return pi < pj
-		}
-		return tasks[i].Urgency > tasks[j].Urgency
-	})
-	io.WriteString(stdout, FormatTaskList(tasks))
-	return 0, nil
+	return d.handleListWithFilters(ctx, []string{"status:pending"}, args[1:], stdout, stderr)
 }
 
 func (d Dispatcher) handleAll(ctx context.Context, args []string, stdout, stderr io.Writer) (int, error) {
-	filterArgs := []string{}
-	for _, arg := range args[1:] {
-		if strings.HasPrefix(arg, "limit:") || strings.HasPrefix(arg, "sort:") ||
-			strings.HasPrefix(arg, "+") || arg == "started" {
-			filterArgs = append(filterArgs, arg)
-		}
-	}
-	filterArgs = append(filterArgs, "export")
-	var outBuf bytes.Buffer
-	code, err := d.runner.Run(ctx, filterArgs, nil, &outBuf, stderr)
-	if code != 0 {
-		return code, err
-	}
-	tasks, err := ParseTaskExport(&outBuf)
-	if err != nil {
-		return 1, nil
-	}
-	sort.Slice(tasks, func(i, j int) bool {
-		pi := priorityOrder(tasks[i].Priority)
-		pj := priorityOrder(tasks[j].Priority)
-		if pi != pj {
-			return pi < pj
-		}
-		return tasks[i].Urgency > tasks[j].Urgency
-	})
-	io.WriteString(stdout, FormatTaskList(tasks))
-	return 0, nil
+	return d.handleListWithFilters(ctx, nil, args[1:], stdout, stderr)
 }
 
 func (d Dispatcher) handleReady(ctx context.Context, args []string, stdout, stderr io.Writer) (int, error) {
-	filterArgs := []string{"+READY"}
-	for _, arg := range args[1:] {
+	return d.handleListWithFilters(ctx, []string{"+READY"}, args[1:], stdout, stderr)
+}
+
+// handleListWithFilters is the shared implementation for list/all/ready.
+// initialFilters seeds the taskwarrior filter; extraArgs are user-supplied
+// filter modifiers (limit:, sort:, +tag, started).
+func (d Dispatcher) handleListWithFilters(ctx context.Context, initialFilters, extraArgs []string, stdout, stderr io.Writer) (int, error) {
+	filterArgs := append([]string(nil), initialFilters...)
+	for _, arg := range extraArgs {
 		if strings.HasPrefix(arg, "limit:") || strings.HasPrefix(arg, "sort:") ||
 			strings.HasPrefix(arg, "+") || arg == "started" {
 			filterArgs = append(filterArgs, arg)
@@ -84,6 +40,7 @@ func (d Dispatcher) handleReady(ctx context.Context, args []string, stdout, stde
 	}
 	tasks, err := ParseTaskExport(&outBuf)
 	if err != nil {
+		fmt.Fprintf(stderr, "error: failed to parse task data: %v\n", err)
 		return 1, nil
 	}
 	sort.Slice(tasks, func(i, j int) bool {
-- 
cgit v1.2.3