From 3ea11bc5d671d962d01b57fa0fba0bda611025fe Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Mon, 23 Mar 2026 08:27:18 +0200 Subject: fix: code quality improvements across lsp, askcli, appconfig, integrationtests - lsp/handlers_completion.go: track collectFirstCompletion goroutine in inflight WaitGroup (goroutine leak fix) - lsp/transport.go: use %w instead of %v for error wrapping - askcli/command_list.go: extract handleListWithFilters shared helper; handleList/handleAll/handleReady are now single-liners - askcli/command_list.go, urgency.go, dep.go: log ParseTaskExport errors to stderr instead of returning 1 silently - appconfig/config_load.go: rename 'any' variable to 'found' to avoid shadowing the built-in identifier - llm/provider.go: add explanatory comment for package-level registry - integrationtests/ask_test.go: add //go:build integration tag; move repoRoot init from init() to TestMain with diagnostic error message Co-Authored-By: Claude Sonnet 4.6 --- internal/askcli/command_urgency.go | 2 ++ 1 file changed, 2 insertions(+) (limited to 'internal/askcli/command_urgency.go') diff --git a/internal/askcli/command_urgency.go b/internal/askcli/command_urgency.go index f2be17a..9dd162e 100644 --- a/internal/askcli/command_urgency.go +++ b/internal/askcli/command_urgency.go @@ -3,6 +3,7 @@ package askcli import ( "bytes" "context" + "fmt" "io" "sort" ) @@ -15,6 +16,7 @@ func (d Dispatcher) handleUrgency(ctx context.Context, stdout, stderr io.Writer) } tasks, err := ParseTaskExport(&outBuf) if err != nil { + fmt.Fprintf(stderr, "error: failed to parse task data: %v\n", err) return 1, nil } sort.Slice(tasks, func(i, j int) bool { -- cgit v1.2.3