From 4958ea5100ebf8d4ff9fd818b7bc59d01989feb4 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Mon, 23 Mar 2026 08:08:57 +0200 Subject: fix: address all HIGH-severity code quality audit findings - lsp/server.go: track request goroutines in inflight WaitGroup to prevent use-after-close writes on shutdown - lsp/llm_client_registry.go: acquire write lock before calling build() to eliminate TOCTOU race on cache population - lsp/handlers_codeaction.go: resolveSimplifyCodeAction now uses PromptCodeActionSimplify{System,User} (was wrongly using rewrite prompts) - askcli/taskexport.go: remove exported MustParseTaskExport to prevent panic on malformed external input; move to unexported test helper - cmd/ask/main.go: print error to stderr before os.Exit - llm/{openai,ollama,openrouter}.go: add interface satisfaction assertions - integrationtests/ask_test.go: replace type assertions with errors.As for robust exec.ExitError unwrapping Co-Authored-By: Claude Sonnet 4.6 --- internal/askcli/taskexport.go | 8 -------- 1 file changed, 8 deletions(-) (limited to 'internal/askcli/taskexport.go') diff --git a/internal/askcli/taskexport.go b/internal/askcli/taskexport.go index 9841821..ca67ef5 100644 --- a/internal/askcli/taskexport.go +++ b/internal/askcli/taskexport.go @@ -32,11 +32,3 @@ func ParseTaskExport(r io.Reader) ([]TaskExport, error) { } return tasks, nil } - -func MustParseTaskExport(data []byte) []TaskExport { - var tasks []TaskExport - if err := json.Unmarshal(data, &tasks); err != nil { - panic(fmt.Sprintf("failed to parse task export JSON: %v", err)) - } - return tasks -} -- cgit v1.2.3