From d985ff9b90cb8476301b2b611023a4332b47a2f0 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Mon, 16 Mar 2026 04:06:39 +0200 Subject: Centralize GPT-5 temperature override into llmutils.ResolveTemperature Eliminates identical temperature resolution logic duplicated in hexaiaction, hexaicli, and lsp packages. Co-Authored-By: Claude Opus 4.6 --- internal/hexaicli/run.go | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) (limited to 'internal/hexaicli/run.go') diff --git a/internal/hexaicli/run.go b/internal/hexaicli/run.go index d485e0c..25ab7c1 100644 --- a/internal/hexaicli/run.go +++ b/internal/hexaicli/run.go @@ -86,21 +86,10 @@ func buildCLIRequest(entry appconfig.SurfaceConfig, provider string, cfg appconf return req } +// cliTemperatureFromEntry resolves the effective temperature for a CLI request, +// delegating GPT-5 override logic to llmutils.ResolveTemperature. func cliTemperatureFromEntry(cfg appconfig.App, provider string, entry appconfig.SurfaceConfig, model string) (float64, bool) { - if entry.Temperature != nil { - return *entry.Temperature, true - } - if cfg.CodingTemperature != nil { - temp := *cfg.CodingTemperature - if provider == "openai" && strings.HasPrefix(strings.ToLower(model), "gpt-5") && temp == 0.2 { - temp = 1.0 - } - return temp, true - } - if provider == "openai" && strings.HasPrefix(strings.ToLower(model), "gpt-5") { - return 1.0, true - } - return 0, false + return llmutils.ResolveTemperature(provider, model, entry.Temperature, cfg.CodingTemperature) } func canonicalProvider(name string) string { -- cgit v1.2.3