From 6f1c8bf7a36eb7044ed7aad30f84664cbbf0d303 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Tue, 17 Mar 2026 11:28:19 +0200 Subject: Fix bugs, remove duplication, and clean up code quality issues - Log swallowed JSON unmarshal errors in stats and LSP handlers - Fix debug log file handle leak in tmuxedit (return closer from initDebugLog) - Check f.Close() errors on write paths in promptstore and tmuxedit - Fix cacheGet TOCTOU race by using single write lock - Fix readInput to use passed stdin reader instead of os.Stdin.Stat() - Remove 45 'moved to' comment tombstones from lsp/handlers.go - Deduplicate canonicalProvider wrappers (use llmutils.CanonicalProvider directly) - Remove SetWindow side effect from stats.TakeSnapshot (pure read now) - Move duplicated splitLines to textutil.SplitLinesBytes - Collapse StatusSink.SetGlobal 10 params into GlobalStatus struct - Simplify LRU touchLocked to in-place delete-and-append Co-Authored-By: Claude Opus 4.6 (1M context) --- internal/hexailsp/run.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) (limited to 'internal/hexailsp/run.go') diff --git a/internal/hexailsp/run.go b/internal/hexailsp/run.go index 68d2954..ec5dbba 100644 --- a/internal/hexailsp/run.go +++ b/internal/hexailsp/run.go @@ -36,8 +36,11 @@ func (tmuxStatusSink) SetLLMStart(provider, model string) error { return tmx.SetStatus(tmx.FormatLLMStartStatus(provider, model)) } -func (tmuxStatusSink) SetGlobal(reqs int64, rpm float64, sent int64, recv int64, provider, model string, scopeRPM float64, scopeReqs int64, window time.Duration) error { - status := tmx.FormatGlobalStatusColored(reqs, rpm, sent, recv, provider, model, scopeRPM, scopeReqs, window) +func (tmuxStatusSink) SetGlobal(gs lsp.GlobalStatus) error { + status := tmx.FormatGlobalStatusColored( + gs.Reqs, gs.RPM, gs.Sent, gs.Recv, + gs.Provider, gs.Model, gs.ScopeRPM, gs.ScopeReqs, gs.Window, + ) return tmx.SetStatus(status) } -- cgit v1.2.3