From 4958ea5100ebf8d4ff9fd818b7bc59d01989feb4 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Mon, 23 Mar 2026 08:08:57 +0200 Subject: fix: address all HIGH-severity code quality audit findings - lsp/server.go: track request goroutines in inflight WaitGroup to prevent use-after-close writes on shutdown - lsp/llm_client_registry.go: acquire write lock before calling build() to eliminate TOCTOU race on cache population - lsp/handlers_codeaction.go: resolveSimplifyCodeAction now uses PromptCodeActionSimplify{System,User} (was wrongly using rewrite prompts) - askcli/taskexport.go: remove exported MustParseTaskExport to prevent panic on malformed external input; move to unexported test helper - cmd/ask/main.go: print error to stderr before os.Exit - llm/{openai,ollama,openrouter}.go: add interface satisfaction assertions - integrationtests/ask_test.go: replace type assertions with errors.As for robust exec.ExitError unwrapping Co-Authored-By: Claude Sonnet 4.6 --- internal/llm/ollama.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'internal/llm/ollama.go') diff --git a/internal/llm/ollama.go b/internal/llm/ollama.go index ade62a9..be93ab0 100644 --- a/internal/llm/ollama.go +++ b/internal/llm/ollama.go @@ -23,6 +23,12 @@ type ollamaClient struct { defaultTemperature *float64 } +// Ensure ollamaClient implements Client and Streamer. +var ( + _ Client = ollamaClient{} + _ Streamer = ollamaClient{} +) + type ollamaChatRequest struct { Model string `json:"model"` Messages []oaMessage `json:"messages"` -- cgit v1.2.3