From 236f6543b093e54157f40ec0c021b35177e1713e Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Thu, 11 Jun 2026 00:16:27 +0300 Subject: Refactor lsp.Server God Object: extract chat and completion subsystems The Server type accumulated two large, tangled feature subsystems (in-editor chat and code completion) alongside its core LSP dispatch role. Pull them into cohesive types that own their state and logic while delegating shared infrastructure back to Server via a back-reference. - Add completionService (completion_service.go): owns the completion cache/throttle state (completionState) and all completion request-handling logic (handleCompletion, plan/jobs/execute, provider-native path, post-processing, message building, prefix heuristics). Methods moved off Server in handlers_completion.go to completionService. - Add chatService (chat_service.go + chat_handlers.go): owns the input-activity clock (lastInput, with its own mutex instead of Server.mu) and all in-editor chat logic (detection, transcript history, message building, edit application, inline prompts) plus the slash-command handlers (chat_commands.go). - Server now holds chat/completion fields, wires them in NewServer, and delegates (dispatch table, didChange, debounce gate) to them. Thin Server shims preserve the existing completion-state API for callers/tests. Pure refactor: no behavior or LSP protocol changes. Tests adjusted only to reach the relocated methods/state via the services. All tests pass with -race; coverage 86.1%. Co-Authored-By: Claude Opus 4.8 --- internal/lsp/document.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'internal/lsp/document.go') diff --git a/internal/lsp/document.go b/internal/lsp/document.go index f7d0bbe..4938925 100644 --- a/internal/lsp/document.go +++ b/internal/lsp/document.go @@ -3,7 +3,6 @@ package lsp import ( "strings" - "time" ) type document struct { @@ -25,9 +24,7 @@ func (s *Server) deleteDocument(uri string) { } func (s *Server) markActivity() { - s.mu.Lock() - s.lastInput = time.Now() - s.mu.Unlock() + s.chatSvc().markActivity() } func (s *Server) getDocument(uri string) *document { -- cgit v1.2.3