From 90a9d57c05c033f19d0c233c8d0454708621d6b9 Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Fri, 22 Aug 2025 19:16:39 +0300
Subject: lsp: always trigger completion on inline semicolon prompts (;text; or
 ';;...;'); relax prefix check accordingly; add tests

---
 internal/lsp/handlers.go | 18 +++++++++++++++---
 1 file changed, 15 insertions(+), 3 deletions(-)

(limited to 'internal/lsp/handlers.go')

diff --git a/internal/lsp/handlers.go b/internal/lsp/handlers.go
index 69ee7ab..9d58a44 100644
--- a/internal/lsp/handlers.go
+++ b/internal/lsp/handlers.go
@@ -706,8 +706,10 @@ func (s *Server) tryLLMCompletion(p CompletionParams, above, current, below, fun
     ctx, cancel := context.WithTimeout(context.Background(), 6*time.Second)
     defer cancel()
 
-    // Only invoke LLM when triggered by one of our trigger characters.
-    if !s.isTriggerEvent(p, current) {
+    // Inline prompt markers (strict ;text; or double-; patterns) explicitly allow triggering.
+    inlinePrompt := lineHasInlinePrompt(current)
+    // Only invoke LLM when triggered by our characters, manual invoke, or inline prompt markers.
+    if !inlinePrompt && !s.isTriggerEvent(p, current) {
         logging.Logf("lsp ", "%scompletion skip=no-trigger line=%d char=%d current=%q%s", logging.AnsiYellow, p.Position.Line, p.Position.Character, trimLen(current), logging.AnsiBase)
         return []CompletionItem{}, true, false
     }
@@ -750,7 +752,7 @@ func (s *Server) tryLLMCompletion(p CompletionParams, above, current, below, fun
         if idx > len(current) { idx = len(current) }
         // Structural triggers allow no prefix
         allowNoPrefix := false
-        if manualInvoke {
+        if manualInvoke || inlinePrompt {
             allowNoPrefix = true
         }
         if idx > 0 {
@@ -1184,6 +1186,16 @@ func isIdentChar(ch byte) bool {
     return (ch >= 'a' && ch <= 'z') || (ch >= 'A' && ch <= 'Z') || (ch >= '0' && ch <= '9') || ch == '_'
 }
 
+// lineHasInlinePrompt returns true if the line contains an inline strict
+// semicolon marker ;text; (no spaces at boundaries) or a double-semicolon
+// pattern recognized by hasDoubleSemicolonTrigger.
+func lineHasInlinePrompt(line string) bool {
+    if _, _, _, ok := findStrictSemicolonTag(line); ok {
+        return true
+    }
+    return hasDoubleSemicolonTrigger(line)
+}
+
 // stripDuplicateAssignmentPrefix removes a duplicated assignment prefix (e.g.,
 // "name :=") from the beginning of the model suggestion when that same prefix
 // already appears immediately to the left of the cursor on the current line.
-- 
cgit v1.2.3