From a5bd7dd1eb63a2be332ecda50fbeccfe5d5de0a8 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Thu, 11 Jun 2026 08:49:20 +0300 Subject: appconfig: split FeatureConfig into cohesive per-subsystem structs The FeatureConfig section was a grab-bag mixing five unrelated non-LLM subsystems (ignore filtering, stats, tmux popup editor, tmux action menu, MCP server). Decompose it into named per-subsystem structs (IgnoreConfig, StatsConfig, TmuxEditConfig, TmuxActionConfig, MCPConfig) embedded into FeatureConfig so the subsystem boundaries are explicit. Embedding keeps Go field promotion intact, so existing flat read access (e.g. cfg.MCPPromptsDir) and the JSON/TOML on-disk shape are unchanged; only composite literals that set these leaf fields directly were updated to the nested form. Add fine-grained, defensive-copy section accessors on App (IgnoreSection, StatsSection, TmuxEditSection, TmuxActionSection, MCPSection) so consumers can depend on a single subsystem's config instead of the whole App God-struct. Decouple slashcommands.NewSyncer to accept appconfig.MCPConfig rather than appconfig.App. All tests pass with -race; appconfig coverage 91.5%, total 86.2%. Co-Authored-By: Claude Opus 4.8 --- internal/slashcommands/syncer.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'internal/slashcommands/syncer.go') diff --git a/internal/slashcommands/syncer.go b/internal/slashcommands/syncer.go index 1268e7b..674b974 100644 --- a/internal/slashcommands/syncer.go +++ b/internal/slashcommands/syncer.go @@ -30,7 +30,8 @@ type Syncer struct { // NewSyncer creates a new syncer and validates the commands directory. // Returns error if directory cannot be created or is not writable. -func NewSyncer(cfg appconfig.App) (*Syncer, error) { +// It depends only on the MCP subsystem config rather than the whole App. +func NewSyncer(cfg appconfig.MCPConfig) (*Syncer, error) { if !cfg.MCPSlashCommandSync { return &Syncer{enabled: false}, nil } -- cgit v1.2.3