From e95f3fdf0a66ba05ba2c8fb7e755e107f9cf7991 Mon Sep 17 00:00:00 2001 From: Paul Buetow Date: Thu, 11 Jun 2026 08:34:41 +0300 Subject: Thread context.Context through blocking I/O entry points Accept ctx as the first parameter on the blocking I/O entry points and propagate it to downstream blocking calls so the work is cancellable from the process entry point: - appconfig.Load / LoadWithOptions: honor ctx before the blocking file reads, returning defaults on a cancelled context. - LSP: lsp.Server.Run(ctx) ties the serve loop to the caller context via a new watchParentContext bridge (cancels the server context, aborting in-flight LLM work). Threaded through hexailsp.Run/RunWithConfig/ RunWithFactory and runtimeconfig.Store.Reload. - MCP: mcp.Server.Run(ctx) stops accepting requests once ctx is cancelled; threaded through hexaimcp.Run/RunWithFactory/RunBackfill. - editor: RunEditor/OpenTempAndEdit/OpenFile take ctx and use exec.CommandContext so a cancelled context kills the editor subprocess; threaded through hexaicli, hexaiaction and askcli call sites. Top-level callers (cmd/hexai-lsp-server, cmd/hexai-mcp-server) now build a signal-cancelled context (SIGINT/SIGTERM) so shutdown tears the run down cleanly. Updated comments to explain the cancellation flow and added cancellation tests for the LSP/MCP loops, editor, and config load. All tests pass with -race; cross-package coverage 86.2%. Co-Authored-By: Claude Opus 4.8 --- internal/tmuxedit/run.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'internal/tmuxedit/run.go') diff --git a/internal/tmuxedit/run.go b/internal/tmuxedit/run.go index da484df..2dd5afe 100644 --- a/internal/tmuxedit/run.go +++ b/internal/tmuxedit/run.go @@ -1,6 +1,7 @@ package tmuxedit import ( + "context" "fmt" "log" "os" @@ -105,7 +106,9 @@ func Run(opts Options) error { func loadConfig(configPath string) appconfig.App { logger := log.New(os.Stderr, "[hexai-tmux-edit] ", log.LstdFlags) lopts := appconfig.LoadOptions{ConfigPath: configPath} - return appconfig.LoadWithOptions(logger, lopts) + // This runner has no signal-aware context of its own; the load is a quick + // local file read, so a background context is sufficient. + return appconfig.LoadWithOptions(context.Background(), logger, lopts) } // debugLog is the debug logger. Set to a real logger via initDebugLog(). -- cgit v1.2.3