summaryrefslogtreecommitdiff
path: root/internal/promptstore/store_test.go
blob: 2c95ad70949b6e279e12caf695c20caaf2acb0ec (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
// Summary: Tests for prompt store operations
package promptstore

import (
	"fmt"
	"os"
	"path/filepath"
	"testing"
	"time"
)

func TestJSONLStore_Get(t *testing.T) {
	t.Run("get existing prompt", func(t *testing.T) {
		tmpDir := t.TempDir()
		store, err := NewJSONLStore(tmpDir)
		if err != nil {
			t.Fatalf("NewJSONLStore() error = %v", err)
		}

		// Create a test prompt first
		testPrompt := &Prompt{
			Name:        "test_prompt",
			Title:       "Test Prompt",
			Description: "A test prompt",
			Messages:    []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Test"}}},
			Created:     time.Now(),
			Updated:     time.Now(),
		}
		if err := store.Create(testPrompt); err != nil {
			t.Fatalf("Create() error = %v", err)
		}

		// Now get it
		got, err := store.Get("test_prompt")
		if err != nil {
			t.Fatalf("Get() error = %v", err)
		}
		if got.Name != "test_prompt" {
			t.Errorf("Get() name = %v, want test_prompt", got.Name)
		}
		if got.Title != "Test Prompt" {
			t.Errorf("Get() title = %v, want Test Prompt", got.Title)
		}
	})

	t.Run("prompt not found", func(t *testing.T) {
		tmpDir := t.TempDir()
		store, err := NewJSONLStore(tmpDir)
		if err != nil {
			t.Fatalf("NewJSONLStore() error = %v", err)
		}

		_, err = store.Get("nonexistent")
		if err == nil {
			t.Error("Get() expected error for nonexistent prompt, got nil")
		}
	})
}

func TestJSONLStore_List(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	// Create test prompts
	for i := 0; i < 7; i++ {
		prompt := &Prompt{
			Name:     fmt.Sprintf("test%d", i),
			Title:    fmt.Sprintf("Test %d", i),
			Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Test"}}},
			Created:  time.Now(),
			Updated:  time.Now(),
		}
		if err := store.Create(prompt); err != nil {
			t.Fatalf("Create() error = %v", err)
		}
	}

	// List all prompts
	prompts, cursor, err := store.List("", 100)
	if err != nil {
		t.Fatalf("List() error = %v", err)
	}

	// Should have all prompts (7 user + 3 built-ins)
	if len(prompts) != 10 {
		t.Errorf("List() got %d prompts, want 10 (7 user + 3 built-ins)", len(prompts))
	}

	// No cursor for full list
	if cursor != "" {
		t.Errorf("List() cursor = %v, want empty", cursor)
	}

	// Test pagination
	prompts1, cursor1, err := store.List("", 3)
	if err != nil {
		t.Fatalf("List() error = %v", err)
	}
	if len(prompts1) != 3 {
		t.Errorf("List() got %d prompts, want 3", len(prompts1))
	}
	if cursor1 == "" {
		t.Error("List() expected cursor, got empty")
	}

	// Get next page
	prompts2, cursor2, err := store.List(cursor1, 3)
	if err != nil {
		t.Fatalf("List() error = %v", err)
	}
	if len(prompts2) != 3 {
		t.Errorf("List() got %d prompts on page 2, want 3", len(prompts2))
	}
	if cursor2 == "" {
		t.Error("List() expected cursor2, got empty")
	}
}

func TestJSONLStore_Create(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	now := time.Now()
	prompt := &Prompt{
		Name:        "test_prompt",
		Title:       "Test Prompt",
		Description: "A test prompt",
		Arguments: []PromptArgument{
			{Name: "input", Description: "Test input", Required: true},
		},
		Messages: []PromptMessage{
			{
				Role: "user",
				Content: MessageContent{
					Type: "text",
					Text: "Test: {{input}}",
				},
			},
		},
		Tags:    []string{"test"},
		Created: now,
		Updated: now,
	}

	// Create prompt
	if err := store.Create(prompt); err != nil {
		t.Fatalf("Create() error = %v", err)
	}

	// Verify it exists
	got, err := store.Get("test_prompt")
	if err != nil {
		t.Fatalf("Get() after Create() error = %v", err)
	}
	if got.Name != prompt.Name {
		t.Errorf("Get() name = %v, want %v", got.Name, prompt.Name)
	}

	// Try to create duplicate
	err = store.Create(prompt)
	if err == nil {
		t.Error("Create() duplicate should fail")
	}
}

func TestJSONLStore_Update(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	now := time.Now()
	prompt := &Prompt{
		Name:        "test_update",
		Title:       "Original Title",
		Description: "Original description",
		Messages:    []PromptMessage{},
		Created:     now,
		Updated:     now,
	}

	// Create initial prompt
	if err := store.Create(prompt); err != nil {
		t.Fatalf("Create() error = %v", err)
	}

	// Update prompt
	prompt.Title = "Updated Title"
	prompt.Description = "Updated description"
	if err := store.Update(prompt); err != nil {
		t.Fatalf("Update() error = %v", err)
	}

	// Verify update
	got, err := store.Get("test_update")
	if err != nil {
		t.Fatalf("Get() after Update() error = %v", err)
	}
	if got.Title != "Updated Title" {
		t.Errorf("Get() title = %v, want Updated Title", got.Title)
	}
}

func TestJSONLStore_Delete(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	now := time.Now()
	prompt := &Prompt{
		Name:        "test_delete",
		Title:       "Delete Me",
		Description: "Will be deleted",
		Messages:    []PromptMessage{},
		Created:     now,
		Updated:     now,
	}

	// Create prompt
	if err := store.Create(prompt); err != nil {
		t.Fatalf("Create() error = %v", err)
	}

	// Delete prompt
	if err := store.Delete("test_delete"); err != nil {
		t.Fatalf("Delete() error = %v", err)
	}

	// Verify deletion
	_, err = store.Get("test_delete")
	if err == nil {
		t.Error("Get() after Delete() should fail")
	}
}

func TestJSONLStore_SearchByTags(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	// Create test prompts with tags
	prompt1 := &Prompt{
		Name:     "test1",
		Title:    "Test 1",
		Tags:     []string{"development", "review"},
		Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Test 1"}}},
		Created:  time.Now(),
		Updated:  time.Now(),
	}
	prompt2 := &Prompt{
		Name:     "test2",
		Title:    "Test 2",
		Tags:     []string{"development"},
		Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Test 2"}}},
		Created:  time.Now(),
		Updated:  time.Now(),
	}
	prompt3 := &Prompt{
		Name:     "test3",
		Title:    "Test 3",
		Tags:     []string{"testing"},
		Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Test 3"}}},
		Created:  time.Now(),
		Updated:  time.Now(),
	}

	if err := store.Create(prompt1); err != nil {
		t.Fatalf("Create() error = %v", err)
	}
	if err := store.Create(prompt2); err != nil {
		t.Fatalf("Create() error = %v", err)
	}
	if err := store.Create(prompt3); err != nil {
		t.Fatalf("Create() error = %v", err)
	}

	// Search for development tag
	results, err := store.SearchByTags([]string{"development"})
	if err != nil {
		t.Fatalf("SearchByTags() error = %v", err)
	}

	if len(results) != 2 {
		t.Errorf("SearchByTags() got %d results, want 2", len(results))
	}

	// Search for multiple tags
	results, err = store.SearchByTags([]string{"development", "review"})
	if err != nil {
		t.Fatalf("SearchByTags() error = %v", err)
	}

	if len(results) != 1 {
		t.Errorf("SearchByTags() got %d results, want 1", len(results))
	}
	if results[0].Name != "test1" {
		t.Errorf("SearchByTags() got prompt %s, want test1", results[0].Name)
	}
}

func TestJSONLStore_LoadAllPrompts_CodeAndFile(t *testing.T) {
	t.Run("loads from both code (built-ins) and user.jsonl", func(t *testing.T) {
		tmpDir := t.TempDir()
		store, err := NewJSONLStore(tmpDir)
		if err != nil {
			t.Fatalf("NewJSONLStore() error = %v", err)
		}

		// Create a user prompt
		userPrompt := &Prompt{
			Name:     "user_test",
			Title:    "User Test",
			Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "User test"}}},
			Created:  time.Now(),
			Updated:  time.Now(),
		}
		if err := store.Create(userPrompt); err != nil {
			t.Fatalf("Create() error = %v", err)
		}

		// List all prompts (should include both built-ins from code and user prompt)
		prompts, _, err := store.List("", 100)
		if err != nil {
			t.Fatalf("List() error = %v", err)
		}

		// Check we have at least the built-ins (save_prompt, update_prompt) + user prompt
		if len(prompts) < 3 {
			t.Errorf("List() got %d prompts, want at least 3 (2 built-ins + 1 user)", len(prompts))
		}

		// Verify built-in prompts are present
		hasBuiltIn := false
		hasUser := false
		for _, p := range prompts {
			if p.Name == "save_prompt" || p.Name == "update_prompt" {
				hasBuiltIn = true
			}
			if p.Name == "user_test" {
				hasUser = true
			}
		}

		if !hasBuiltIn {
			t.Error("List() missing built-in prompts (save_prompt or update_prompt)")
		}
		if !hasUser {
			t.Error("List() missing user prompt (user_test)")
		}
	})

	t.Run("built-ins take precedence over user prompts with same name", func(t *testing.T) {
		tmpDir := t.TempDir()
		store, err := NewJSONLStore(tmpDir)
		if err != nil {
			t.Fatalf("NewJSONLStore() error = %v", err)
		}

		// Get the built-in save_prompt (from code)
		builtIn, err := store.Get("save_prompt")
		if err != nil {
			t.Fatalf("Get(save_prompt) error = %v", err)
		}
		originalTitle := builtIn.Title

		// Manually add a conflicting prompt to user.jsonl (bypass protection)
		// This simulates a conflict scenario
		jStore := store.(*JSONLStore)
		conflictPrompt := &Prompt{
			Name:     "save_prompt",
			Title:    "Conflicting Title",
			Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Conflict"}}},
			Created:  time.Now(),
			Updated:  time.Now(),
		}
		// Write directly to user.jsonl without using Create (which has protection)
		userPrompts := []Prompt{*conflictPrompt}
		if err := jStore.writePromptsToFile("user.jsonl", userPrompts); err != nil {
			t.Fatalf("writePromptsToFile() error = %v", err)
		}

		// Get save_prompt again - should return built-in from code, not user version
		result, err := store.Get("save_prompt")
		if err != nil {
			t.Fatalf("Get(save_prompt) after conflict error = %v", err)
		}

		if result.Title != originalTitle {
			t.Errorf("Get(save_prompt) title = %v, want %v (built-in should take precedence)", result.Title, originalTitle)
		}
	})
}

func TestJSONLStore_BuiltInProtection_Update(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	// Get the built-in save_prompt
	builtIn, err := store.Get("save_prompt")
	if err != nil {
		t.Fatalf("Get(save_prompt) error = %v", err)
	}

	// Try to update it
	builtIn.Title = "Modified Title"
	err = store.Update(builtIn)

	// Should fail with clear error message
	if err == nil {
		t.Fatal("Update() on built-in prompt should fail")
	}

	expectedMsg := "cannot update built-in prompt: save_prompt"
	if !contains(err.Error(), expectedMsg) {
		t.Errorf("Update() error = %v, want error containing %q", err, expectedMsg)
	}
}

func TestJSONLStore_BuiltInProtection_Delete(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	// Verify save_prompt exists
	_, err = store.Get("save_prompt")
	if err != nil {
		t.Fatalf("Get(save_prompt) error = %v (built-in should exist)", err)
	}

	// Try to delete it
	err = store.Delete("save_prompt")

	// Should fail with clear error message
	if err == nil {
		t.Fatal("Delete() on built-in prompt should fail")
	}

	expectedMsg := "cannot delete built-in prompt: save_prompt"
	if !contains(err.Error(), expectedMsg) {
		t.Errorf("Delete() error = %v, want error containing %q", err, expectedMsg)
	}

	// Verify it still exists
	_, err = store.Get("save_prompt")
	if err != nil {
		t.Error("Get(save_prompt) after failed delete should still work")
	}
}

func TestJSONLStore_Create_NameConflictWithBuiltIn(t *testing.T) {
	tmpDir := t.TempDir()
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	// Try to create a prompt with the same name as a built-in
	conflictPrompt := &Prompt{
		Name:     "save_prompt",
		Title:    "My Custom Save",
		Messages: []PromptMessage{{Role: "user", Content: MessageContent{Type: "text", Text: "Custom"}}},
		Created:  time.Now(),
		Updated:  time.Now(),
	}

	err = store.Create(conflictPrompt)

	// Should fail with clear error message
	if err == nil {
		t.Fatal("Create() with built-in name should fail")
	}

	expectedMsg := "prompt already exists: save_prompt"
	if !contains(err.Error(), expectedMsg) {
		t.Errorf("Create() error = %v, want error containing %q", err, expectedMsg)
	}
}

func TestJSONLStore_BuiltInPromptsLoadedFromCode(t *testing.T) {
	tmpDir := t.TempDir()

	// Create store (built-ins loaded from code, not from file)
	store, err := NewJSONLStore(tmpDir)
	if err != nil {
		t.Fatalf("NewJSONLStore() error = %v", err)
	}

	// Verify save_prompt exists (loaded from code)
	savePrompt, err := store.Get("save_prompt")
	if err != nil {
		t.Fatalf("Get(save_prompt) error = %v (should be loaded from code)", err)
	}
	if savePrompt.Name != "save_prompt" {
		t.Errorf("Get(save_prompt) name = %v, want save_prompt", savePrompt.Name)
	}

	// Verify update_prompt exists (loaded from code)
	updatePrompt, err := store.Get("update_prompt")
	if err != nil {
		t.Fatalf("Get(update_prompt) error = %v (should be loaded from code)", err)
	}
	if updatePrompt.Name != "update_prompt" {
		t.Errorf("Get(update_prompt) name = %v, want update_prompt", updatePrompt.Name)
	}

	// Verify both have correct tags
	if !containsTag(savePrompt.Tags, "meta") {
		t.Error("save_prompt should have 'meta' tag")
	}
	if !containsTag(updatePrompt.Tags, "meta") {
		t.Error("update_prompt should have 'meta' tag")
	}

	// Verify no default.jsonl file was created
	defaultPath := filepath.Join(tmpDir, "default.jsonl")
	if _, err := os.Stat(defaultPath); !os.IsNotExist(err) {
		t.Error("default.jsonl should not be created (built-ins loaded from code)")
	}
}

// Helper function to check if a string contains a substring
func contains(s, substr string) bool {
	return len(s) >= len(substr) && (s == substr || len(s) > len(substr) && containsSubstring(s, substr))
}

func containsSubstring(s, substr string) bool {
	for i := 0; i <= len(s)-len(substr); i++ {
		if s[i:i+len(substr)] == substr {
			return true
		}
	}
	return false
}

// Helper function to check if a slice contains a tag
func containsTag(tags []string, tag string) bool {
	for _, t := range tags {
		if t == tag {
			return true
		}
	}
	return false
}