diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-19 20:13:34 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-19 20:13:34 +0300 |
| commit | c67b34fca467fc4e5e8aba7a1b8929d8aa55a833 (patch) | |
| tree | 501c6ec53c4cd0e5d5bac9c871711996c4a5d1d8 /cmd/ioworkload/scenario_polling.go | |
| parent | 6ef2ad7d15b3a11e643f312884c222ac53165623 (diff) | |
y6 follow-up: tolerate unsupported epoll_pwait2 kernels
Diffstat (limited to 'cmd/ioworkload/scenario_polling.go')
| -rw-r--r-- | cmd/ioworkload/scenario_polling.go | 31 |
1 files changed, 28 insertions, 3 deletions
diff --git a/cmd/ioworkload/scenario_polling.go b/cmd/ioworkload/scenario_polling.go index 6a97f57..1531511 100644 --- a/cmd/ioworkload/scenario_polling.go +++ b/cmd/ioworkload/scenario_polling.go @@ -1,6 +1,7 @@ package main import ( + "errors" "fmt" "runtime" "syscall" @@ -29,6 +30,7 @@ func pollingEpoll() error { return fmt.Errorf("epoll_ctl add: %w", err) } + pwait2Supported := true deadline := time.Now().Add(5 * time.Second) for time.Now().Before(deadline) { if err := waitAndDrain(epfd, pipefd, callEpollWait); err != nil { @@ -37,8 +39,16 @@ func pollingEpoll() error { if err := waitAndDrain(epfd, pipefd, callEpollPwait); err != nil { return err } - if err := waitAndDrain(epfd, pipefd, callEpollPwait2); err != nil { - return err + if pwait2Supported { + if err := waitAndDrain(epfd, pipefd, callEpollPwait2); err != nil { + if !isUnsupportedEpollPwait2Err(err) { + return err + } + if drainErr := drainWakeByte(pipefd[0]); drainErr != nil { + return drainErr + } + pwait2Supported = false + } } } @@ -57,8 +67,12 @@ func waitAndDrain(epfd int, pipefd [2]int, waitFn func(int, []unix.EpollEvent) ( if ready < 1 { return fmt.Errorf("epoll wait returned %d ready events", ready) } + return drainWakeByte(pipefd[0]) +} + +func drainWakeByte(readFD int) error { var buf [1]byte - if _, err := syscall.Read(pipefd[0], buf[:]); err != nil { + if _, err := syscall.Read(readFD, buf[:]); err != nil { return fmt.Errorf("drain wake byte: %w", err) } return nil @@ -119,3 +133,14 @@ func callEpollPwait2(epfd int, events []unix.EpollEvent) (int, error) { } return int(r1), nil } + +func isUnsupportedEpollPwait2Err(err error) bool { + if err == nil { + return false + } + var errno syscall.Errno + if !errors.As(err, &errno) { + return false + } + return errno == syscall.ENOSYS || errno == syscall.ENOTSUP +} |
