summaryrefslogtreecommitdiff
path: root/docs
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-05-30 10:02:43 +0300
committerPaul Buetow <paul@buetow.org>2026-05-30 10:02:43 +0300
commit97631f8e50665ee374d88929743079cfaa9fad47 (patch)
treea8306e53712d8819c304aef1eb0c85ab42dd011a /docs
parentd685ed30e772a3f04858a235d59405d624ac98f4 (diff)
integrationtests: scope leaked-temp-dir detection to a per-test prefix (q10)
TestCleanupLeakedWorkloadTempDirCaughtByAssertion was order/concurrency dependent: passed in isolation but its detection scanned the shared system temp root (os.TempDir) for ANY "ioworkload-" directory via a before/after diff. Real ioworkload scenario workloads legitimately create ioworkload-<scenario>-* dirs in that same root while they run (in parallel under `mage integrationTest`), so this test both falsely attributed them as leaks and, worse, RemoveAll'd them out from under the still-running tests. Fix: scope both detection and cleanup to a prefix unique to this single test invocation (PID + sanitized t.Name()) via listWorkloadTempDirsWithPrefix and newLeakedDirs. Other tests' temp dirs can no longer be observed or deleted. Also fixed a latent detection bug: the intentional-leak workload script hard-coded /tmp instead of os.TempDir(), so detection silently failed whenever $TMPDIR differed from /tmp. The mktemp template now uses os.TempDir(). Removed the dead assertNoNewWorkloadTempDirs helper (defined, never called). Verified: mage build OK; mage test green across repeated runs; mage generate produces no diff; gofmt clean. A stress run with decoy ioworkload-<scenario>-* dirs confirms they survive untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'docs')
0 files changed, 0 insertions, 0 deletions