diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-23 19:56:33 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-23 19:56:33 +0300 |
| commit | 940bd6e00cb28af5f076828f6c90e6f3bc729cd8 (patch) | |
| tree | a88377adc5c9677cd4aa4e2dd0c2416df3debe71 /internal/c | |
| parent | ae40acb21b2de686156af6f4344b3698a6c0afab (diff) | |
5c remove tracepoint ID adjacency dependency from aggregate pairing
Generated exit handlers now pass the explicit enter trace ID
(SYS_ENTER_X) to ior_on_syscall_exit instead of relying on the
implicit enter_id == exit_id + 1 arithmetic invariant. filter.c
compares directly against the passed enter ID.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Diffstat (limited to 'internal/c')
| -rw-r--r-- | internal/c/filter.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/internal/c/filter.c b/internal/c/filter.c index 88c4fa0..5585c12 100644 --- a/internal/c/filter.c +++ b/internal/c/filter.c @@ -78,7 +78,7 @@ static __always_inline int ior_on_syscall_enter(__u32 tid, __u32 enter_trace_id) return state.emit_event != 0; } -static __always_inline int ior_on_syscall_exit(__u32 tid, __u32 exit_trace_id, __s64 ret) { +static __always_inline int ior_on_syscall_exit(__u32 tid, __u32 enter_trace_id, __s64 ret) { __u64 now; __u64 duration = 0; __u8 emit_event = 1; @@ -92,8 +92,10 @@ static __always_inline int ior_on_syscall_exit(__u32 tid, __u32 exit_trace_id, _ if (now >= state->start_ns) duration = now - state->start_ns; - // A tracepoint pair uses enter_id == exit_id + 1 in this codebase. - if (state->enter_trace_id == exit_trace_id + 1) + // Pair aggregate stats using the explicit enter_trace_id passed by the + // generated exit handler, avoiding any numeric adjacency assumption + // between kernel-assigned enter and exit tracepoint IDs. + if (state->enter_trace_id == enter_trace_id) ior_update_syscall_aggregate(state->enter_trace_id, duration, ret); emit_event = state->emit_event; |