diff options
| author | Paul Buetow <paul@buetow.org> | 2026-02-24 21:19:09 +0200 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-02-24 21:19:09 +0200 |
| commit | 6ea8920dac3b7e3868707a84e58a5d7e10ebbbf3 (patch) | |
| tree | 63138d32b6197522855a0b69e3c09068a0e1df41 /internal/flags/flags.go | |
| parent | 93d587a6f5ae453907de3d5556866b60bac405cb (diff) | |
flamegraph: remove external tool path and document native generation
Diffstat (limited to 'internal/flags/flags.go')
| -rw-r--r-- | internal/flags/flags.go | 19 |
1 files changed, 3 insertions, 16 deletions
diff --git a/internal/flags/flags.go b/internal/flags/flags.go index 5bde9c6..9354bc3 100644 --- a/internal/flags/flags.go +++ b/internal/flags/flags.go @@ -21,8 +21,6 @@ var ( pidFilter atomic.Int64 ) -const flamegraphToolDefault = "" - var ( validCollapsedFields = []string{ "path", @@ -60,13 +58,10 @@ type Flags struct { FlamegraphName string TUIExportEnable bool - // To convert ior data into collapsed format + // To convert ior data into native SVG format IorDataFile string CollapsedFields []string CountField string - - // To generate the Flamegraph SVGs - FlamegraphTool string } func Get() Flags { @@ -110,22 +105,14 @@ func parse() { flag.StringVar(&singleton.FlamegraphName, "name", "default", "Name of the flamegraph, used to generate the SVG file") flag.BoolVar(&singleton.TUIExportEnable, "tuiExport", true, "Enable writing TUI snapshot export files") - flag.StringVar(&singleton.IorDataFile, "ior", "", "IOR data file to convert into collapsed format") + flag.StringVar(&singleton.IorDataFile, "ior", "", "IOR data file to convert into native SVG flamegraph") fields := flag.String("fields", "", fmt.Sprintf("Comma separated list of fields to collapse, valid are: %v", validCollapsedFields)) flag.StringVar(&singleton.CountField, "count", "count", - fmt.Sprintf("Count field to collaps, valid are: %v", validCollapsedCounts)) - - // https://github.com/brendangregg/FlameGraph - flag.StringVar(&singleton.FlamegraphTool, "flamegraphTool", - "", "Path to the flamegraph tool (e.g. flamegraph.pl or inferno-flamegraph)") + fmt.Sprintf("Count field to collapse, valid are: %v", validCollapsedCounts)) flag.Parse() pidFilter.Store(int64(singleton.PidFilter)) - if singleton.FlamegraphTool == "" { - singleton.FlamegraphTool = flamegraphToolDefault - } - singleton.TracepointsToAttach = extractTracepointFlags(*tracepointsToAttach) singleton.TracepointsToExclude = extractTracepointFlags(*tracepointsToExclude) |