diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-09 10:53:18 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-09 10:53:18 +0300 |
| commit | 8da473aed2c3e901615294df398b26db5aea6032 (patch) | |
| tree | a62807c29441c56776910558ece56361202f7bb2 /internal/flags/flags_test.go | |
| parent | f3aed5203b309f1d452a5dc3f05c1ecba8e1134b (diff) | |
add auto-reset timer for dashboard aggregates
Live flamegraph trie and stats engine grow unboundedly during long
traces. Add a periodic auto-reset (same effect as the 'r' key) so they
stay bounded.
- New CLI flag -resetTimer=30s (default 30s, 0 disables).
- Hotkey I cycles the cadence: off -> 15s -> 30s -> 60s -> 5m -> off.
Custom intervals (e.g. -resetTimer=47s) advance to the first preset
greater than the current value, then wrap to off.
- autoResetTickMsg carries a generation counter so changing the cadence
drops in-flight ticks scheduled under the previous interval.
- Dashboard chrome shows 'auto-reset: 30s' or 'auto-reset: off'.
Diffstat (limited to 'internal/flags/flags_test.go')
| -rw-r--r-- | internal/flags/flags_test.go | 40 |
1 files changed, 40 insertions, 0 deletions
diff --git a/internal/flags/flags_test.go b/internal/flags/flags_test.go index f5274d8..77c167c 100644 --- a/internal/flags/flags_test.go +++ b/internal/flags/flags_test.go @@ -171,3 +171,43 @@ func TestParseInvalidTracepointRegexReturnsError(t *testing.T) { t.Fatalf("unexpected error: %v", err) } } + +func TestParseResetTimerDefault(t *testing.T) { + cfg, err := parseForTest(t) + if err != nil { + t.Fatalf("parse returned error: %v", err) + } + if cfg.ResetTimer != DefaultResetTimer { + t.Fatalf("default reset timer = %v, want %v", cfg.ResetTimer, DefaultResetTimer) + } +} + +func TestParseResetTimerOverride(t *testing.T) { + cfg, err := parseForTest(t, "-resetTimer", "45s") + if err != nil { + t.Fatalf("parse returned error: %v", err) + } + if cfg.ResetTimer != 45*time.Second { + t.Fatalf("reset timer = %v, want 45s", cfg.ResetTimer) + } +} + +func TestParseResetTimerZeroDisables(t *testing.T) { + cfg, err := parseForTest(t, "-resetTimer", "0") + if err != nil { + t.Fatalf("parse returned error: %v", err) + } + if cfg.ResetTimer != 0 { + t.Fatalf("reset timer = %v, want 0 (disabled)", cfg.ResetTimer) + } +} + +func TestParseResetTimerNegativeReturnsError(t *testing.T) { + _, err := parseForTest(t, "-resetTimer", "-5s") + if err == nil { + t.Fatalf("expected parse error for negative reset timer") + } + if !strings.Contains(err.Error(), "invalid resetTimer") { + t.Fatalf("unexpected error: %v", err) + } +} |
