flags: change default flamegraph order to comm-first

2 files changed, 15 insertions, 1 deletions

diff --git a/internal/flags/flags.go b/internal/flags/flags.go
index dccbe0d..8785ea9 100644
--- a/internal/flags/flags.go
+++ b/internal/flags/flags.go
@@ -144,7 +144,7 @@ func parse() {
 	// If future kernels regress, add targeted exclusions here.
 
 	if *fields == "" {
-		singleton.CollapsedFields = []string{"pid", "path", "tracepoint"}
+		singleton.CollapsedFields = []string{"comm", "path", "tracepoint"}
 	} else {
 		singleton.CollapsedFields = strings.Split(*fields, ",")
 	}
diff --git a/internal/flags/flags_test.go b/internal/flags/flags_test.go
index b4d47d2..872a597 100644
--- a/internal/flags/flags_test.go
+++ b/internal/flags/flags_test.go
@@ -74,3 +74,17 @@ func TestParseLiveDefaults(t *testing.T) {
 		t.Fatalf("default live interval = %v, want %v", cfg.LiveInterval, time.Second)
 	}
 }
+
+func TestParseDefaultCollapsedFieldsOrder(t *testing.T) {
+	cfg := parseForTest(t)
+
+	want := []string{"comm", "path", "tracepoint"}
+	if len(cfg.CollapsedFields) != len(want) {
+		t.Fatalf("default collapsed fields len = %d, want %d", len(cfg.CollapsedFields), len(want))
+	}
+	for i := range want {
+		if cfg.CollapsedFields[i] != want[i] {
+			t.Fatalf("default collapsed fields[%d] = %q, want %q", i, cfg.CollapsedFields[i], want[i])
+		}
+	}
+}