diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-29 17:31:03 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-29 17:31:03 +0300 |
| commit | 372d01873ccdc7db9a076c12577d5b1ab6288d10 (patch) | |
| tree | 352f6c5add860bf8d9644f533c25dc7624379ad0 /internal/generate/classify_test.go | |
| parent | b184674de2bc4f3cb27aaa31bcc64c3f3976ecff (diff) | |
test(syncfs): lock in FS family + fd kind classification
Audit of syncfs(2) confirmed the existing tracing is correct: single fd
arg (fd=args[0], KindFd), FamilyFS like its fsync/fdatasync/
sync_file_range siblings, and an int 0/-1 return that stays Unclassified
(plain ret_event). No code or generated artifacts changed.
Add lock-in tests so a stray reclassification trips CI:
- TestClassifySyncFamilyFdSyscallsByName: enter -> KindFd for the
fsync/fdatasync/syncfs/sync_file_range group.
- TestClassifyExitSyncfs: exit -> KindRet.
- sync-family FamilyFS assertions in TestClassifySyncallFamily.
- syncfs added to the ret-UNCLASSIFIED list.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'internal/generate/classify_test.go')
| -rw-r--r-- | internal/generate/classify_test.go | 53 |
1 files changed, 53 insertions, 0 deletions
diff --git a/internal/generate/classify_test.go b/internal/generate/classify_test.go index 768e367..fecbb93 100644 --- a/internal/generate/classify_test.go +++ b/internal/generate/classify_test.go @@ -315,6 +315,59 @@ func TestClassifySocketFdSyscallsByName(t *testing.T) { } } +// TestClassifySyncFamilyFdSyscallsByName locks in that the filesystem-sync +// family (fsync/fdatasync/syncfs/sync_file_range) is classified as KindFd on +// enter. Each of these takes an open file descriptor as args[0]: +// - int fsync(int fd) +// - int fdatasync(int fd) +// - int syncfs(int fd) +// - int sync_file_range(int fd, off64_t offset, off64_t nbytes, unsigned flags) +// +// so their enter tracepoint carries a leading fd field and must capture +// fd=args[0] into a fd_event (KindFd), matching the generated +// handle_sys_enter_* handlers. (Plain sync() takes no args and is KindNull; +// it is asserted separately in the classification table test.) +func TestClassifySyncFamilyFdSyscallsByName(t *testing.T) { + tests := []string{ + "fsync", + "fdatasync", + "syncfs", + "sync_file_range", + } + for _, name := range tests { + t.Run(name, func(t *testing.T) { + r := ClassifyFormat(&Format{ + Name: "sys_enter_" + name, + ExternalFields: []Field{ + {Type: "long", Name: "__syscall_nr"}, + {Type: "int", Name: "fd"}, + }, + }) + if r.Kind != KindFd { + t.Errorf("%s: got kind %d, want KindFd", name, r.Kind) + } + }) + } +} + +// TestClassifyExitSyncfs locks in that the syncfs exit tracepoint is classified +// as KindRet. syncfs(2) returns int (0 on success, -1 on error) and transfers +// no bytes, so its exit format carries a single "ret" field and must map to a +// plain ret_event (KindRet, Unclassified) — matching the generated +// sys_exit_syncfs handler and its fsync/fdatasync siblings. +func TestClassifyExitSyncfs(t *testing.T) { + r := ClassifyFormat(&Format{ + Name: "sys_exit_syncfs", + ExternalFields: []Field{ + {Type: "long", Name: "__syscall_nr"}, + {Type: "long", Name: "ret"}, + }, + }) + if r.Kind != KindRet { + t.Errorf("exit_syncfs: got kind %d, want KindRet", r.Kind) + } +} + // TestClassifyExitGetpeername locks in that the getpeername exit tracepoint is // classified as KindRet. getpeername(2) returns int (0 on success, -1 on // error), so its exit format carries a single "ret" field and must map to a |
