diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-30 16:35:39 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-30 16:35:39 +0300 |
| commit | a74da2f75d8088793ee6f7e2cc46ba19803a350f (patch) | |
| tree | 0368c226edc4f53c0fb98ddd94e98646a7a69404 /internal/generate/codegen_test.go | |
| parent | 5210f20b16a224f58117ffb71b2a0691c02a50ed (diff) | |
test(generate): lock in bind syscall classification
Audit of bind(2): int bind(int sockfd, const struct sockaddr *addr,
socklen_t addrlen). Verified the existing classification is correct and
consistent with its socket-setup siblings connect/listen/accept/
getsockname/getpeername:
- KindFd, capturing ev->fd = args[0] (the sockfd); the addr pointer and
addrlen are not captured.
- FamilyNetwork.
- Exit is UNCLASSIFIED (returns 0/-1, no transferred byte count).
No implementation or doc changes were needed (docs/syscall-tracing-plan.md
already lists bind under Network and fd; drift test green). Added
regression coverage:
- FormatBind/FormatExitBind fixtures mirroring the real kernel tracepoint.
- TestGenerateBindHandler with negative guards (no probe_read on the
sockaddr, no fd capture from args[1]/args[2], exit stays UNCLASSIFIED).
- bind + connect/listen/getsockname/getpeername added to the
family (FamilyNetwork) and ret-classification (UNCLASSIFIED) lock-in
lists.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'internal/generate/codegen_test.go')
| -rw-r--r-- | internal/generate/codegen_test.go | 36 |
1 files changed, 36 insertions, 0 deletions
diff --git a/internal/generate/codegen_test.go b/internal/generate/codegen_test.go index 68a372e..be94724 100644 --- a/internal/generate/codegen_test.go +++ b/internal/generate/codegen_test.go @@ -48,6 +48,42 @@ func TestGenerateModuleHandlers(t *testing.T) { requireContains(t, finitOut, "ev->fd = (__s32)ctx->args[0];") } +// TestGenerateBindHandler locks in the generated BPF C for bind(2): +// +// int bind(int sockfd, const struct sockaddr *addr, socklen_t addrlen) +// +// bind assigns an address to a socket and returns 0 on success or -1 on error. +// Its sockfd is at args[0], so the enter handler is a KindFd fd_event capturing +// ev->fd = args[0] — matching its socket siblings connect/listen/accept/ +// getsockname/getpeername. The addr pointer (args[1]) and addrlen (args[2]) must +// NOT be captured: bind reads no path and copies no userspace buffer we track. +// The exit handler is a plain ret_event marked UNCLASSIFIED (0/-1, no byte +// count), so it must not carry a READ/WRITE/TRANSFER classification. +func TestGenerateBindHandler(t *testing.T) { + output := generateFromPair(t, FormatBind, FormatExitBind) + + // Enter: KindFd fd_event capturing the sockfd from args[0]. + requireContains(t, output, `SEC("tracepoint/syscalls/sys_enter_bind")`) + requireContains(t, output, "struct fd_event *ev = bpf_ringbuf_reserve(&event_map, sizeof(struct fd_event), 0);") + requireContains(t, output, "ev->event_type = ENTER_FD_EVENT;") + requireContains(t, output, "ev->trace_id = SYS_ENTER_BIND;") + requireContains(t, output, "ev->fd = (__s32)ctx->args[0];") + + // Negative guards: the sockaddr pointer (args[1]) must never be read as a + // path/buffer, and addrlen (args[2]) must not be captured as another fd. + requireNotContains(t, output, "bpf_probe_read_user_str") + requireNotContains(t, output, "ev->fd = (__s32)ctx->args[1];") + requireNotContains(t, output, "ev->fd = (__s32)ctx->args[2];") + + // Exit: plain ret_event, UNCLASSIFIED (bind returns 0/-1, no byte count). + requireContains(t, output, `SEC("tracepoint/syscalls/sys_exit_bind")`) + requireContains(t, output, "struct ret_event *ev = bpf_ringbuf_reserve(&event_map, sizeof(struct ret_event), 0);") + requireContains(t, output, "ev->ret_type = UNCLASSIFIED;") + requireNotContains(t, output, "ev->ret_type = READ_CLASSIFIED;") + requireNotContains(t, output, "ev->ret_type = WRITE_CLASSIFIED;") + requireNotContains(t, output, "ev->ret_type = TRANSFER_CLASSIFIED;") +} + func TestGeneratePidfdGetfdHandlerUsesPidfdArgument(t *testing.T) { output := generateFromPair(t, FormatPidfdGetfd, FormatExitPidfdGetfd) |
