summaryrefslogtreecommitdiff
path: root/internal/generate/family_test.go
diff options
context:
space:
mode:
authorPaul Buetow <paul@buetow.org>2026-05-29 17:22:56 +0300
committerPaul Buetow <paul@buetow.org>2026-05-29 17:22:56 +0300
commit4df620818f603564b2e6f4def6052baa72b2fbb1 (patch)
tree133ea6c3d95304dc823319aaecab8dca8d8866da /internal/generate/family_test.go
parent8e524f9ca7f8c105f395bfa111f1b052206bc836 (diff)
utime/utimes: classify as FS family (fix Misc misclassification)
utime(2) and utimes(2) change a file's access/modification times by a real filesystem path (filename at args[0]). The path was already captured (KindPathname), but both syscalls fell through to FamilyMisc instead of joining their siblings utimensat/futimesat in FamilyFS. Add them to fsSyscalls and regenerate; the only generated change is trace IDs 1034-1037 flipping FamilyMisc -> FamilyFS. Lock-in coverage: - family_test.go asserts utime/utimes/utimensat/futimesat are all FamilyFS. - classify_test.go + FormatUtime fixture assert utime is KindPathname with PathnameField "filename" (path captured even though it is a char* string, unlike domain/host name args). - New ioworkload scenarios utime-basic/utimes/enoent and integration tests TestUtimeBasic/Utimes/Enoent verify the path is captured at runtime, including on the ENOENT error path. Docs updated: moved utime/utimes from Misc to FS in docs/syscall-tracing-plan.md to keep the drift tests green. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'internal/generate/family_test.go')
-rw-r--r--internal/generate/family_test.go13
1 files changed, 13 insertions, 0 deletions
diff --git a/internal/generate/family_test.go b/internal/generate/family_test.go
index 4a5ccc5..f6c9ca4 100644
--- a/internal/generate/family_test.go
+++ b/internal/generate/family_test.go
@@ -43,6 +43,19 @@ func TestClassifySyscallFamily(t *testing.T) {
{"sys_exit_gettimeofday", FamilyTime},
{"sys_enter_sched_yield", FamilySched},
{"sys_enter_openat", FamilyFS},
+ // utime(2)/utimes(2) change a file's access and modification times by
+ // path (filename at args[0] is a real filesystem path, captured as
+ // KindPathname). They are filesystem-metadata syscalls and share
+ // FamilyFS with their siblings utimensat(2) and futimesat(2); they must
+ // NOT fall through to Misc. Assert all four siblings so a stray
+ // reclassification of any one trips this test. Keep in sync with the FS
+ // list in docs/syscall-tracing-plan.md.
+ {"sys_enter_utime", FamilyFS},
+ {"sys_exit_utime", FamilyFS},
+ {"sys_enter_utimes", FamilyFS},
+ {"sys_exit_utimes", FamilyFS},
+ {"sys_enter_utimensat", FamilyFS},
+ {"sys_enter_futimesat", FamilyFS},
{"sys_enter_epoll_wait", FamilyPolling},
{"sys_enter_io_uring_enter", FamilyAIO},
{"sys_enter_bpf", FamilySecurity},