diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-30 16:35:39 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-30 16:35:39 +0300 |
| commit | a74da2f75d8088793ee6f7e2cc46ba19803a350f (patch) | |
| tree | 0368c226edc4f53c0fb98ddd94e98646a7a69404 /internal/generate/retclassify_test.go | |
| parent | 5210f20b16a224f58117ffb71b2a0691c02a50ed (diff) | |
test(generate): lock in bind syscall classification
Audit of bind(2): int bind(int sockfd, const struct sockaddr *addr,
socklen_t addrlen). Verified the existing classification is correct and
consistent with its socket-setup siblings connect/listen/accept/
getsockname/getpeername:
- KindFd, capturing ev->fd = args[0] (the sockfd); the addr pointer and
addrlen are not captured.
- FamilyNetwork.
- Exit is UNCLASSIFIED (returns 0/-1, no transferred byte count).
No implementation or doc changes were needed (docs/syscall-tracing-plan.md
already lists bind under Network and fd; drift test green). Added
regression coverage:
- FormatBind/FormatExitBind fixtures mirroring the real kernel tracepoint.
- TestGenerateBindHandler with negative guards (no probe_read on the
sockaddr, no fd capture from args[1]/args[2], exit stays UNCLASSIFIED).
- bind + connect/listen/getsockname/getpeername added to the
family (FamilyNetwork) and ret-classification (UNCLASSIFIED) lock-in
lists.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'internal/generate/retclassify_test.go')
| -rw-r--r-- | internal/generate/retclassify_test.go | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/internal/generate/retclassify_test.go b/internal/generate/retclassify_test.go index 29e2b0f..f26d803 100644 --- a/internal/generate/retclassify_test.go +++ b/internal/generate/retclassify_test.go @@ -99,6 +99,16 @@ func TestClassifyRetUnclassified(t *testing.T) { // exit must stay UNCLASSIFIED (plain ret_event), exactly like its // pid/tid-returning Process siblings setsid/getsid/getpid/getppid above. "set_tid_address", + // bind(2) assigns an address to a socket and returns int 0 on success or + // -1 on error — a status code, NOT a transferred byte count. Its exit must + // stay UNCLASSIFIED (plain ret_event), exactly like its socket-setup + // siblings connect/listen/getsockname/getpeername (asserted alongside it), + // so it is never mistaken for a recvfrom/sendto-style byte transfer. + "bind", + "connect", + "listen", + "getsockname", + "getpeername", } for _, name := range unclassified { if got := ClassifyRet("sys_exit_" + name); got != Unclassified { |
