diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-30 11:00:53 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-30 11:00:53 +0300 |
| commit | 97a1b7a907c3237445643b95496bf84404e5cf4c (patch) | |
| tree | 4a9fe740ab715af7fb8356b0f779c91cc7f09563 /internal/generate/testdata.go | |
| parent | 271cda4e5b478a9f51ac98544e34de768a7e69ae (diff) | |
test(generate): lock in mkdirat path capture at args[1]
Audit of mkdirat(2) found the tracing implementation correct: the generated
BPF handler reads the pathname from args[1] (after the dirfd at args[0]),
while the sibling mkdir(2) reads from args[0] (no dirfd). Both are
KindPathname / FamilyFS with an UNCLASSIFIED return, consistent with
mknod/mknodat and docs/syscall-tracing-plan.md. The arg index is data-driven
from the kernel format via FieldNumber, so no source change was needed.
Add lock-in unit tests and real-format fixtures asserting:
- mkdirat captures the path from args[1], NOT args[0] (negative guard)
- mkdir captures the path from args[0]
- mkdirat/mkdir/mknodat share FamilyFS and KindPathname
- FieldNumber(pathname) = 1 for mkdirat, 0 for mkdir
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Diffstat (limited to 'internal/generate/testdata.go')
| -rw-r--r-- | internal/generate/testdata.go | 67 |
1 files changed, 67 insertions, 0 deletions
diff --git a/internal/generate/testdata.go b/internal/generate/testdata.go index 25392b1..5b38cfd 100644 --- a/internal/generate/testdata.go +++ b/internal/generate/testdata.go @@ -2052,3 +2052,70 @@ format: print fmt: "0x%lx", REC->ret ` + +// FormatMkdirat is real sysfs data for mkdirat(2): the pathname argument sits +// at args[1], AFTER the dirfd at args[0]. Captured from a Linux 7.0 kernel, +// which also exposes the __data_loc __pathname_val trailing field. The +// generator must read the path from args[1] (the dfd at args[0] is NOT a path). +const FormatMkdirat = `name: sys_enter_mkdirat +ID: 899 +format: + field:unsigned short common_type; offset:0; size:2; signed:0; + field:unsigned char common_flags; offset:2; size:1; signed:0; + field:unsigned char common_preempt_count; offset:3; size:1; signed:0; + field:int common_pid; offset:4; size:4; signed:1; + + field:int __syscall_nr; offset:8; size:4; signed:1; + field:int dfd; offset:16; size:8; signed:0; + field:const char * pathname; offset:24; size:8; signed:0; + field:umode_t mode; offset:32; size:8; signed:0; + field:__data_loc char[] __pathname_val; offset:40; size:4; signed:0; + +print fmt: "dfd: 0x%08lx, pathname: 0x%08lx, mode: 0x%08lx", ((unsigned long)(REC->dfd)), ((unsigned long)(REC->pathname)), ((unsigned long)(REC->mode)) +` + +const FormatExitMkdirat = `name: sys_exit_mkdirat +ID: 898 +format: + field:unsigned short common_type; offset:0; size:2; signed:0; + field:unsigned char common_flags; offset:2; size:1; signed:0; + field:unsigned char common_preempt_count; offset:3; size:1; signed:0; + field:int common_pid; offset:4; size:4; signed:1; + + field:int __syscall_nr; offset:8; size:4; signed:1; + field:long ret; offset:16; size:8; signed:1; + +print fmt: "0x%lx", REC->ret +` + +// FormatMkdir is the sibling mkdir(2): it has NO dirfd, so the pathname is the +// first argument at args[0]. This is the key contrast with mkdirat above and +// guards against accidentally sharing a single arg index between the two. +const FormatMkdir = `name: sys_enter_mkdir +ID: 901 +format: + field:unsigned short common_type; offset:0; size:2; signed:0; + field:unsigned char common_flags; offset:2; size:1; signed:0; + field:unsigned char common_preempt_count; offset:3; size:1; signed:0; + field:int common_pid; offset:4; size:4; signed:1; + + field:int __syscall_nr; offset:8; size:4; signed:1; + field:const char * pathname; offset:16; size:8; signed:0; + field:umode_t mode; offset:24; size:8; signed:0; + +print fmt: "pathname: 0x%08lx, mode: 0x%08lx", ((unsigned long)(REC->pathname)), ((unsigned long)(REC->mode)) +` + +const FormatExitMkdir = `name: sys_exit_mkdir +ID: 900 +format: + field:unsigned short common_type; offset:0; size:2; signed:0; + field:unsigned char common_flags; offset:2; size:1; signed:0; + field:unsigned char common_preempt_count; offset:3; size:1; signed:0; + field:int common_pid; offset:4; size:4; signed:1; + + field:int __syscall_nr; offset:8; size:4; signed:1; + field:long ret; offset:16; size:8; signed:1; + +print fmt: "0x%lx", REC->ret +` |
