diff options
| author | Paul Buetow <paul@buetow.org> | 2026-03-06 16:40:24 +0200 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-03-06 16:40:24 +0200 |
| commit | a1b48634add8c5cdd3d362b592bb6f6eb5bf69ee (patch) | |
| tree | 1b5f62b62cfd94a9b259b3fd3332d2ece88d7cff /internal/generate | |
| parent | 1d72e80ed340564c6c2d37366e20896aa00341e2 (diff) | |
fix: return fallback for unknown trace ids (task 383)
Diffstat (limited to 'internal/generate')
| -rw-r--r-- | internal/generate/typesgo.go | 4 | ||||
| -rw-r--r-- | internal/generate/typesgo_test.go | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/internal/generate/typesgo.go b/internal/generate/typesgo.go index ee24845..06ed49a 100644 --- a/internal/generate/typesgo.go +++ b/internal/generate/typesgo.go @@ -186,7 +186,7 @@ func writeTraceIdStringMethod(b *strings.Builder) { b.WriteString(`func (s TraceId) String() string { str, ok := traceId2String[s] if !ok { - panic(fmt.Sprintf("no string representation for trace ID %d found", s)) + return fmt.Sprintf("unknown_trace_id_%d", s) } return str } @@ -198,7 +198,7 @@ func writeTraceIdNameMethod(b *strings.Builder) { b.WriteString(`func (s TraceId) Name() string { str, ok := traceId2Name[s] if !ok { - panic(fmt.Sprintf("no name for trace ID %d found", s)) + return fmt.Sprintf("unknown_trace_id_%d", s) } return str } diff --git a/internal/generate/typesgo_test.go b/internal/generate/typesgo_test.go index 89dafa8..f600582 100644 --- a/internal/generate/typesgo_test.go +++ b/internal/generate/typesgo_test.go @@ -240,7 +240,7 @@ func TestGenerateTypesGoTraceIdMethods(t *testing.T) { requireContains(t, output, "func (s TraceId) String() string") requireContains(t, output, "func (s TraceId) Name() string") - requireContains(t, output, `panic(fmt.Sprintf("no string representation for trace ID %d found", s))`) + requireContains(t, output, `return fmt.Sprintf("unknown_trace_id_%d", s)`) } func TestGenerateTypesGoPackageDecl(t *testing.T) { |