diff options
| author | Paul Buetow <paul@buetow.org> | 2026-05-13 19:35:02 +0300 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-05-13 19:35:02 +0300 |
| commit | f4a814df4e39ff5547a88d4f5d37ae6fe159cc76 (patch) | |
| tree | 24410b41efdabbf037d0efc4ee8cb577252faf9c /internal/tui | |
| parent | e6b85dd4222eb1660b591f5dbf6e2b58dfae3bfa (diff) | |
refactor: move TraceFilter and tracepoint selector logic out of flags.Config
- Add tracepoints.Selector type with ShouldAttach method and ParseSelector
constructor, replacing the raw TracepointsToAttach/TracepointsToExclude
regex slices on flags.Config.
- Add flags.BuildTraceFilter as a standalone function replacing the
Config.TraceFilter() method, keeping filter-building logic out of the
config struct.
- Remove stale ShouldIAttachTracepoint noise-filter entry from Magefile.
- Add selector_test.go with full coverage of ParseSelector and ShouldAttach.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to 'internal/tui')
| -rw-r--r-- | internal/tui/tui.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/internal/tui/tui.go b/internal/tui/tui.go index 2cebaf2..695bd02 100644 --- a/internal/tui/tui.go +++ b/internal/tui/tui.go @@ -986,9 +986,10 @@ func (m *Model) beginTraceCmd() tea.Cmd { return m.tracer.beginCmd(m.runtime, m.filters.current()) } -// filterFromConfig delegates to the canonical Config.TraceFilter method. +// filterFromConfig delegates to flags.BuildTraceFilter to resolve the active +// event filter from the CLI configuration fields. func filterFromConfig(cfg flags.Config) globalfilter.Filter { - return cfg.TraceFilter() + return flags.BuildTraceFilter(cfg) } // setProcessFilters updates the proc pid/tid, rebinds filter process constraints, |