From 63a20d8498bf161d16e8a8c8cc0b096a8355aa6f Mon Sep 17 00:00:00 2001
From: Paul Buetow <paul@buetow.org>
Date: Sun, 31 May 2026 19:22:22 +0300
Subject: test(readahead): add end-to-end integration coverage

readahead(2) was traced (KindFd enter fd_event from args[0], UNCLASSIFIED
exit ret_event) but had no integration or ioworkload scenario coverage,
unlike its sibling sync_file_range. Add readwrite-readahead and
readwrite-readahead-ebadf scenarios plus TestReadwriteReadahead /
TestReadwriteReadaheadEbadf, asserting enter_readahead capture with path
attribution, zero attributed bytes (readahead returns 0/-1, not a byte
count, so it is correctly UNCLASSIFIED), and positive end-to-end duration.

No classification change: inspection confirms KindFd / UNCLASSIFIED is
correct per man 2 readahead; bytesFromRet returns 0 for UNCLASSIFIED so
the 0/-1 return is never misattributed as bytes.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
---
 cmd/ioworkload/scenario_readwrite.go | 45 ++++++++++++++++++++++++++++++++++++
 cmd/ioworkload/scenarios.go          |  2 ++
 2 files changed, 47 insertions(+)

(limited to 'cmd/ioworkload')

diff --git a/cmd/ioworkload/scenario_readwrite.go b/cmd/ioworkload/scenario_readwrite.go
index c69e588..02fab53 100644
--- a/cmd/ioworkload/scenario_readwrite.go
+++ b/cmd/ioworkload/scenario_readwrite.go
@@ -251,6 +251,51 @@ func readwriteWritev() error {
 	return nil
 }
 
+// readwriteReadahead opens a file, writes data, then calls readahead(2) on it.
+// readahead(fd, offset, count) initiates non-blocking readahead so subsequent
+// reads are served from the page cache. Despite its ssize_t prototype it returns
+// 0 on success / -1 on error (it does NOT return a byte count and transfers no
+// bytes to userspace), so ior classifies it KindFd / UNCLASSIFIED. The scenario
+// exercises the enter fd_event (fd at args[0]) and the exit ret_event end-to-end.
+func readwriteReadahead() error {
+	dir, cleanup, err := makeTempDir("readwrite-readahead")
+	if err != nil {
+		return err
+	}
+	defer cleanup()
+
+	path := filepath.Join(dir, "readaheadfile.txt")
+	fd, err := syscall.Open(path, syscall.O_RDWR|syscall.O_CREAT, 0o644)
+	if err != nil {
+		return fmt.Errorf("open: %w", err)
+	}
+	defer syscall.Close(fd)
+
+	if _, err := syscall.Write(fd, []byte("readahead test data")); err != nil {
+		return fmt.Errorf("write: %w", err)
+	}
+
+	// readahead(fd, offset=0, count=4096): prime the page cache for the file.
+	_, _, errno := syscall.Syscall(syscall.SYS_READAHEAD, uintptr(fd), 0, 4096)
+	if errno != 0 {
+		return fmt.Errorf("readahead: %w", errno)
+	}
+	return nil
+}
+
+// readwriteReadaheadEbadf calls readahead(2) on an invalid fd.
+// The syscall fails with EBADF, but ior captures the enter_readahead tracepoint
+// because arguments are read on syscall entry before the kernel returns an error.
+func readwriteReadaheadEbadf() error {
+	for i := 0; i < 5; i++ {
+		_, _, errno := syscall.Syscall(syscall.SYS_READAHEAD, 99999, 0, 4096)
+		if errno == 0 {
+			return fmt.Errorf("expected EBADF, but readahead succeeded")
+		}
+	}
+	return nil
+}
+
 // readwriteWronlyRead opens a file O_WRONLY, then attempts to read from it.
 // The read fails with EBADF, but ior should capture the enter_read tracepoint
 // because arguments are read on syscall entry before the kernel returns an error.
diff --git a/cmd/ioworkload/scenarios.go b/cmd/ioworkload/scenarios.go
index 6503db7..000750a 100644
--- a/cmd/ioworkload/scenarios.go
+++ b/cmd/ioworkload/scenarios.go
@@ -27,6 +27,8 @@ var scenarios = map[string]func() error{
 	"readwrite-rdonly-write":        readwriteRdonlyWrite,
 	"readwrite-pread-invalid":       readwritePreadInvalid,
 	"readwrite-pwrite-invalid":      readwritePwriteInvalid,
+	"readwrite-readahead":           readwriteReadahead,
+	"readwrite-readahead-ebadf":     readwriteReadaheadEbadf,
 	"retbytes-phase-a":              retbytesPhaseA,
 	"socket-basic":                  socketBasic,
 	"socketpair-basic":              socketpairBasic,
-- 
cgit v1.2.3